Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a new handy crate
yaml-edit, which allows to modify bender YAML files reliably e.g. forbender cloneandbender snapshotThe current approach is a bit brittle, since it is essentially text matching, and for instance
axialso matchesaxi_riscv_atomics. Also multi-line YAML specifications are not supported.The caveat is currently that the added comments are lost i.e. "Temporary override by Bender...". Replacing or adding comments is currently not supported by
yaml-edit. Alternatively, we could open a PR to add it.yaml-editpulls in a couple of dependencies, but it could potentially be worth it since it also allows other nice features in the future e.g.bender add/removeto add/remove dependencies from the manifest.