Conversation
Member
|
Thanks for the pull requests. The tests typically mock the authentication API provider, check existing tests for inspiration. Documentation should be added to https://github.com/python-social-auth/social-docs/. |
Member
|
@codex review |
nijel
reviewed
Sep 17, 2026
| "defusedxml>=0.7.1", | ||
| "oauthlib>=3.3.1", | ||
| "PyJWT[crypto]>=2.13.0", | ||
| "python-cas>=1.7.2", |
Member
There was a problem hiding this comment.
This should probably go to an extra, not be part of core deps like Google OneTap or Shopify.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1986 +/- ##
==========================================
- Coverage 89.19% 89.00% -0.20%
==========================================
Files 345 346 +1
Lines 13926 13956 +30
Branches 698 700 +2
==========================================
Hits 12421 12421
- Misses 1262 1292 +30
Partials 243 243
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This commit introduce support for the CAS protocol using python-cas library.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces support for the CAS protocol using python-cas library.
It is tested using zulip (for the client) and django-cas-server (for the cas server).
I'm not very confident about how to write the test for this. I'm interested to know if you recommend any code or documentation interesting to get that task done