Skip to content

SCADS specific code in comm should be moved into scalaengine #40

Description

@rxin

My understanding is that the comm folder provides the infrastructure for messaging support.

Most stuff in Messages.scala are really only relevant to SCADS-engine. They should probably be moved into engine.

Activity

  1. marmbrus commented on Nov 15, 2010

    @marmbrus
    Member

    while i agree with this idea in principle, its going to require a fair amount of refactoring. Right now the message handler is hard coded to accept a certain set of messages. This is why these messages are defined in comm and not scalaengine.

  2. stephentu commented on Nov 15, 2010

    @stephentu
    Member

    another reason that messages are defined in comm is due to issues w/ the typer, which is a limitation of the scala compiler plugin framework (messages defined in the same compliation pass are typechecked before the auto-generated methods are added, but we need the typer to run before we can auto-generate methods).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions