Repository navigation
Conversation
…for the simmed_ms fixture
MSv2Store.close() unconditionally released the structure and subtable factories, so closing a store created for a write evicted cached state still in use by the DataTree the dataset came from, forcing an expensive recomputation of the structure on subsequent access. Stores now carry an owns_factories flag. msv2_store_from_dataset() constructs its store with owns_factories=False, since it borrows the factories from the originating store. The main table factory is still released unconditionally: closing the underlying arcae Table is what flushes writes to disk, and arcae exposes no separate flush. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
10 of 29 tasks
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
arcae 0.4.x deprecates lockoptions and warns when it is supplied, which fails CI under -Werror. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to xarray-ms.
We would appreciate it if you could add:
doc/source/changelog.rst.📚 Documentation preview 📚: https://xarray-ms--170.org.readthedocs.build/en/170/