Repository navigation
Relocate x86 GDT before kernel handoff - #14
Closed
wangrunji0408 wants to merge 1 commit into
Closed
wangrunji0408 wants to merge 1 commit into
wangrunji0408 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
rboot has inherited the firmware GDT since the initial implementation (
f4c027e). The GDTR base therefore remains in the low identity-mapped address range when control is handed to the kernel. Once the kernel replaces the firmware page tables, later descriptor-table access can fault. The recent zCore rboot update exposed this pre-existing handoff bug; it did not introduce the missing relocation.Verification
cargo fmt --checkcargo clippy --target x86_64-unknown-uefi -- -D warningscargo check --target aarch64-unknown-uefi./example-kernel/test.shmainand passes with this change