Repository navigation
Re-export speech types used in navigator decls - #269
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
0 open findings
What changed in this PR
Re-exports speech-related types from @readium/navigator to avoid requiring consumers to depend directly on @readium/speech.
Changes:
- Added explicit speech preference getter types.
- Re-exported speech settings, playback state, and preference types.
- Bumped navigator to 2.12.1 and documented the fix.
| File | Description |
|---|---|
navigator/src/readaloud/preferences/ReadAloudPreferencesEditor.ts |
Adds explicit speech preference types. |
navigator/src/readaloud/index.ts |
Re-exports speech types from navigator. |
navigator/package.json |
Bumps the package version. |
navigator/CHANGELOG.MD |
Documents the declaration-generation fix. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export speech types used in navigator so that you do not need to add
@readium/speechas a dependency.