Repository navigation
Match a Collection docblock name with a leading backslash - #548
Merged
TomasVotruba merged 1 commit intoNov 2, 2026
Merged
Conversation
Member
|
LGTM, thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NarrowArrayCollectionToCollectionRectorandUnionCollectionTagValueNodeNarrowerwrite\Doctrine\Common\Collections\Collectioninto a docblock, with a leading backslash.UnionCollectionTagValueNodeNarrower::isCollectionIdentifierTypeNode()andCollectionTagValueNodeAnalyzer::detect()only match the name without it, so the narrowing stops halfway:@param mixed[]|\Doctrine\Common\Collections\Collection $collectionand no native type.With
importNames()this was hidden: the name importer shortens the name toCollectionbefore the next pass. Without it, the two TypedCollections set fixtures fail on main. They also fail with rectorphp/rector-src#8909, which runs the post rectors only after the rules finish.The new test runs the two fixtures without
importNames().