Skip to content

Add performancelab r650 - #887

Merged
openshift-merge-bot[bot] merged 1 commit into
redhat-performance:mainfrom
akrzos:add_perflab_r650
Sep 21, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
redhat-performance:mainfrom
akrzos:add_perflab_r650

Conversation

@akrzos

@akrzos akrzos commented Sep 17, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features
    • Added configuration support for the R650 hardware model, including disk mapping and virtual machine count defaults.

@openshift-ci
openshift-ci Bot requested review from jtaleric and mcornea September 17, 2026 18:57
@coderabbitai

coderabbitai Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 33 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: bd0c8a80-0258-4573-a3ff-02634bf05054

📥 Commits

Reviewing files that changed from the base of the PR and between fb53f06 and 3af97a3.

📒 Files selected for processing (1)
  • ansible/vars/lab.yml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 131a54de-b033-4304-8f82-7d9737e519ae

📥 Commits

Reviewing files that changed from the base of the PR and between 330c2ee and 4b11380.

📒 Files selected for processing (1)
  • ansible/vars/lab.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The performance lab configuration adds r650 hardware install disk and VM count mappings.

Changes

R650 lab configuration

Layer / File(s) Summary
R650 hardware and VM settings
ansible/vars/lab.yml
Adds the r650 disk by-path mapping and sets VM counts to default: 4 and nvme0n1: 5.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 4b113

This scoped configuration change introduces no established merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding the r650 configuration for performancelab.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@agurenko agurenko left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcornea

mcornea commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

/lgtm

@mcornea

mcornea commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

/approve

@openshift-ci

openshift-ci Bot commented Sep 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agurenko, mcornea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 6f6bc6f into redhat-performance:main Sep 21, 2026
3 checks passed
@akrzos
akrzos deleted the add_perflab_r650 branch September 21, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants