Skip to content

Remove on-cluster object storage deployment support - #889

Merged
openshift-merge-bot[bot] merged 1 commit into
redhat-performance:mainfrom
akrzos:remove_on_cluster_object_store
Sep 21, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
redhat-performance:mainfrom
akrzos:remove_on_cluster_object_store

Conversation

@akrzos

@akrzos akrzos commented Sep 18, 2026 •

Copy link
Copy Markdown
Member

Object storage is now exclusively available as a bastion service via setup_bastion_object_store. Removes setup_object_store variable, templates, and related tasks from MNO/SNO post-install roles.

Summary by CodeRabbit

  • Removed Features
    • Removed automatic RustFS object-store deployment and configuration from post-cluster installation.
    • Removed RustFS image mirroring, sample settings, and related ingress host configuration.
  • New Features
    • Added optional Metal3 setup during single-node OpenShift post-cluster installation when enabled.

@coderabbitai

coderabbitai Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: redhat-performance/jetlag/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 6b05b4be-0387-4858-98af-a6df2dd2da0a

📥 Commits

Reviewing files that changed from the base of the PR and between 92f4cde and d1a2a0b.

📒 Files selected for processing (1)
  • ansible/roles/create-inventory/defaults/main/dns.yml
💤 Files with no reviewable changes (1)
  • ansible/roles/create-inventory/defaults/main/dns.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change removes RustFS object-store defaults, templates, deployment tasks, image mirroring, sample variables, and DNS entries from the MNO, SNO, and ACM setup paths. The SNO role keeps Metal3 setup as a top-level task.

Changes

Object-store removal

Layer / File(s) Summary
MNO object-store cleanup
ansible/roles/mno-post-cluster-install/...
The MNO role no longer defines RustFS defaults, creates object-store configuration, applies the object-store manifest, or includes the object-store template.
SNO object-store cleanup
ansible/roles/sno-post-cluster-install/...
The SNO role no longer defines RustFS defaults, creates object-store configuration, applies the object-store manifest, or includes the object-store template. The Metal3 setup task is top-level.
ACM image-sync and DNS cleanup
ansible/roles/sync-acm-d/tasks/main.yml, ansible/vars/sync-acm-d.sample.yml, ansible/roles/create-inventory/defaults/main/dns.yml
The ACM sync role no longer mirrors the RustFS image. Sample variables and ingress route defaults no longer define RustFS object-store settings.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: mcornea

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing on-cluster object storage deployment support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@akrzos
akrzos requested review from mcornea and removed request for josecastillolema and rsevilla87 September 18, 2026 14:24

@mcornea mcornea left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can also remove the object-store ingress route dns record

Object storage is now exclusively available as a bastion service via setup_bastion_object_store. Removes setup_object_store variable, templates, and related tasks from MNO/SNO post-install roles.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@akrzos
akrzos force-pushed the remove_on_cluster_object_store branch from 92f4cde to d1a2a0b Compare September 21, 2026 12:22
@akrzos
akrzos requested a review from mcornea September 21, 2026 12:23
@openshift-ci

openshift-ci Bot commented Sep 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mcornea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit b67e7ae into redhat-performance:main Sep 21, 2026
3 checks passed
@akrzos
akrzos deleted the remove_on_cluster_object_store branch September 21, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants