DOC-7045: Fix dead academic-source link and the link checker that missed it - #3934
Open
andy-stark-redis wants to merge 1 commit into
Open
Conversation
…sed it The Count-Min Sketch page's academic-source PDF link (dimacs.rutgers.edu) 404s; replaced with the paper's DOI. The link checker never caught it because it hasn't run successfully once since it was added: the pinned lychee-action commit predates an upstream fix for the v0.24.2 tarball's subfolder layout, so every scheduled run crashed in the installer before checking any link, and no tracking issue was ever opened as a result. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Contributor
Contributor
🧠 Redis MemoryFound 5 related items from repository history (5 new this commit):
Memory updated at 7ced929 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dimacs.rutgers.eduPDF link in the Count-Min Sketch page's Academic sources section with the paper's DOI (https://doi.org/10.1016/j.jalgor.2003.12.001), which resolves.lycheeverse/lychee-actionto a commit that postdates its fix for the v0.24.2 tarball's subfolder layout. The previously pinned SHA predated that fix, so the "Check links" step crashed in its own installer on every scheduled run since the workflow was added — before checking a single URL — and because the crash happened before the "flag broken links" step, no tracking issue was ever opened either. That's why the dead PDF link went unreported; it wasn't a PDF-specific gap in the checker's link validation.Test plan
link_checkworkflow (gh workflow run link_check.yaml) and confirm the "Check links" step completes instead of failing in the lychee-action installer.action.ymlcontains the subfolder-detection fix.Fixes DOC-7045.
🤖 Generated with Claude Code
Note
Low Risk
Documentation URL swap and a third-party GitHub Action SHA bump; no application, auth, or data-handling changes.
Overview
Fixes DOC-7045 by addressing both the broken citation and the CI step that never reported it.
The Count-Min Sketch Academic sources entry now points at the paper’s DOI (
https://doi.org/10.1016/j.jalgor.2003.12.001) instead of a 404dimacs.rutgers.eduPDF URL.The
link_checkworkflow re-pinslycheeverse/lychee-actionto a commit after the installer fix for v0.24.2 tarballs that extract into a subfolder. The old pin assumed a flat layout, so Check links failed during install on every run and never validated URLs or opened tracking issues—explaining why the dead PDF went unnoticed.Reviewed by Cursor Bugbot for commit 7ced929. Bugbot is set up for automated code reviews on this repo. Configure here.