Repository navigation
Raise reflex-components-lucide and reflex-hosting-cli floors - #7813
Conversation
`pip install -U --pre reflex==0.11.0a1` kept reflex-components-lucide 1.1.1 and reflex-hosting-cli 0.2.1, because the floors still accepted them, so an in-place upgrade missed the digit-icon fix for dynamic `rx.icon` (#7674) and the hosting-cli PyYAML fix (#7670), both landed after those tags. Floor both siblings at the .dev0 of their next version, per the sibling dependency floor rule: newest tags on main are reflex-components-lucide-v1.1.1 and reflex-hosting-cli-v0.2.1, so `>= 1.1.2.dev0` and `>= 0.2.2.dev0`. The published 1.1.2a1 and 0.2.2a1 already satisfy them; releasing reflex lifts them to the first published versions. Found in the reflex 0.11.0a1 pre-release testing (FINDING-042). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dxjadq3qkhKnqZR2b9WBFi
[Medium impact] The PR appears safe to merge. SummaryRaises the minimum versions of
Acknowledged by Reviews (1) · Last reviewed commit: "Raise reflex-components-lucide and refle..." · Reviewed by Greptile |
Merging this PR will degrade performance by 5.37%1 warning
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing |
|
CodSpeed is red here ( Generated by Claude Code |
`pip install -U --pre reflex==0.11.0a1` kept reflex-components-lucide 1.1.1 and reflex-hosting-cli 0.2.1, because the floors still accepted them, so an in-place upgrade missed the digit-icon fix for dynamic `rx.icon` (#7674) and the hosting-cli PyYAML fix (#7670), both landed after those tags. Floor both siblings at the .dev0 of their next version, per the sibling dependency floor rule: newest tags on main are reflex-components-lucide-v1.1.1 and reflex-hosting-cli-v0.2.1, so `>= 1.1.2.dev0` and `>= 0.2.2.dev0`. The published 1.1.2a1 and 0.2.2a1 already satisfy them; releasing reflex lifts them to the first published versions. Found in the reflex 0.11.0a1 pre-release testing (FINDING-042). Claude-Session: https://claude.ai/code/session_01Dxjadq3qkhKnqZR2b9WBFi Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 4c4ace8)
…the train Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dxjadq3qkhKnqZR2b9WBFi
Type of change
Description
Found in the reflex 0.11.0a1 pre-release testing (FINDING-042).
pip install -U --pre reflex==0.11.0a1keepsreflex-components-lucide1.1.1 andreflex-hosting-cli0.2.1, because the root floors still accept them. An in-place upgrade therefore misses two fixes that landed after those tags:rx.icon(S.icon_name)withgrid_2x_2renders blank and logsDynamicIcon not foundBoth are workspace siblings, so this PR follows the "Sibling dependency floors" rule in CLAUDE.md:
mainarereflex-components-lucide-v1.1.1andreflex-hosting-cli-v0.2.1. The*-v1.1.2a1and*-v0.2.2a1tags are on the release branch, not on main. Main builds as1.1.2.devNand0.2.2.devN.reflex-components-lucide >= 1.1.2.dev0andreflex-hosting-cli >= 0.2.2.dev0.git log reflex-components-lucide-v1.1.1..origin/main -- packages/reflex-components-lucideshows Fix blank digit-x-digit icons in dynamic rx.icon and lighten the icon gallery #7674.git log reflex-hosting-cli-v0.2.1..origin/main -- packages/reflex-hosting-clishows fix(hosting-cli): fail cloud config when PyYAML is missing #7670.Checks
uv lock --check: the lockfile is unchanged, because workspace siblings are recorded as editable.check_min_deps.py reflex: PASS.check_min_deps.py --check-dev-pins reflex: exits 1, as it already does onmain. It lists the existing.dev0floors (reflex-base, -components-code, -components-core, -components-radix) plus the two added here. This is the expected pre-release state, and the release process lifts these floors.No unit test: this PR only changes dependency floors.
Generated by Claude Code