Skip to content

Raise reflex-components-lucide and reflex-hosting-cli floors - #7813

Merged
FarhanAliRaza merged 1 commit into
mainfrom
fix/raise-lucide-hosting-floors
Nov 11, 2026
Merged

FarhanAliRaza merged 1 commit into
mainfrom
fix/raise-lucide-hosting-floors

Conversation

@masenf

@masenf masenf commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description

Found in the reflex 0.11.0a1 pre-release testing (FINDING-042).

pip install -U --pre reflex==0.11.0a1 keeps reflex-components-lucide 1.1.1 and reflex-hosting-cli 0.2.1, because the root floors still accept them. An in-place upgrade therefore misses two fixes that landed after those tags:

Both are workspace siblings, so this PR follows the "Sibling dependency floors" rule in CLAUDE.md:

  • The newest tags reachable from main are reflex-components-lucide-v1.1.1 and reflex-hosting-cli-v0.2.1. The *-v1.1.2a1 and *-v0.2.2a1 tags are on the release branch, not on main. Main builds as 1.1.2.devN and 0.2.2.devN.
  • New floors: reflex-components-lucide >= 1.1.2.dev0 and reflex-hosting-cli >= 0.2.2.dev0.
  • git log reflex-components-lucide-v1.1.1..origin/main -- packages/reflex-components-lucide shows Fix blank digit-x-digit icons in dynamic rx.icon and lighten the icon gallery #7674. git log reflex-hosting-cli-v0.2.1..origin/main -- packages/reflex-hosting-cli shows fix(hosting-cli): fail cloud config when PyYAML is missing #7670.
  • PyPI already has 1.1.2a1 and 0.2.2a1, which satisfy the new floors. Releasing reflex lifts the floors to the first published versions.

Checks

  • uv lock --check: the lockfile is unchanged, because workspace siblings are recorded as editable.
  • check_min_deps.py reflex: PASS.
  • check_min_deps.py --check-dev-pins reflex: exits 1, as it already does on main. It lists the existing .dev0 floors (reflex-base, -components-code, -components-core, -components-radix) plus the two added here. This is the expected pre-release state, and the release process lifts these floors.
  • pre-commit is clean on the changed files.

No unit test: this PR only changes dependency floors.


Generated by Claude Code

View guided diff Turn on auto-fix

`pip install -U --pre reflex==0.11.0a1` kept reflex-components-lucide 1.1.1
and reflex-hosting-cli 0.2.1, because the floors still accepted them, so an
in-place upgrade missed the digit-icon fix for dynamic `rx.icon` (#7674) and
the hosting-cli PyYAML fix (#7670), both landed after those tags.

Floor both siblings at the .dev0 of their next version, per the sibling
dependency floor rule: newest tags on main are reflex-components-lucide-v1.1.1
and reflex-hosting-cli-v0.2.1, so `>= 1.1.2.dev0` and `>= 0.2.2.dev0`. The
published 1.1.2a1 and 0.2.2a1 already satisfy them; releasing reflex lifts
them to the first published versions.

Found in the reflex 0.11.0a1 pre-release testing (FINDING-042).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dxjadq3qkhKnqZR2b9WBFi
@masenf
masenf requested a review from a team as a code owner November 11, 2026 09:13
@masenf masenf added this to the v0.11.0 milestone Nov 11, 2026
@masenf masenf added the on deck PRs lined up to review / merge next label Nov 11, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Raises the minimum versions of reflex-components-lucide and reflex-hosting-cli so upgrades cannot keep the older releases that lack these fixes.

  • Reflex upgrades now require newer Lucide and hosting CLI releases.

Acknowledged by masenf: no unit test was added because this PR only changes dependency floors. The development-pin check failure is intentional before release; release preparation lifts those floors.

Reviews (1) · Last reviewed commit: "Raise reflex-components-lucide and refle..." · Reviewed by Greptile

@codspeed

codspeed Bot commented Nov 11, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 5.37%

1 warning

⚠️ 17 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

❌ 2 regressed benchmarks
✅ 149 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ test_route_matching[1000] 47.8 µs 51 µs -6.37%
❌ test_process_event_burst_independent_tokens[1] 2.7 ms 2.8 ms -4.35%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing fix/raise-lucide-hosting-floors (d1baa85) with main (2d71015)

Open in CodSpeed

@masenf

masenf commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator Author

CodSpeed is red here (test_route_matching[1000] -6.4%, test_process_event_burst_independent_tokens[1] -4.4%), but this PR doesn't cause it. Both benchmarks show the same 4–6% drop on every PR in this batch. This PR only raises two dependency floors in pyproject.toml and adds a news fragment, and the workspace installs the same editable packages either way, so no benchmarked code changes. CodSpeed is not a required check; leaving it for acknowledgement on CodSpeed.


Generated by Claude Code

@FarhanAliRaza
FarhanAliRaza merged commit 4c4ace8 into main Nov 11, 2026
169 of 171 checks passed
@FarhanAliRaza
FarhanAliRaza deleted the fix/raise-lucide-hosting-floors branch November 11, 2026 13:47
masenf added a commit that referenced this pull request Nov 11, 2026
`pip install -U --pre reflex==0.11.0a1` kept reflex-components-lucide 1.1.1
and reflex-hosting-cli 0.2.1, because the floors still accepted them, so an
in-place upgrade missed the digit-icon fix for dynamic `rx.icon` (#7674) and
the hosting-cli PyYAML fix (#7670), both landed after those tags.

Floor both siblings at the .dev0 of their next version, per the sibling
dependency floor rule: newest tags on main are reflex-components-lucide-v1.1.1
and reflex-hosting-cli-v0.2.1, so `>= 1.1.2.dev0` and `>= 0.2.2.dev0`. The
published 1.1.2a1 and 0.2.2a1 already satisfy them; releasing reflex lifts
them to the first published versions.

Found in the reflex 0.11.0a1 pre-release testing (FINDING-042).

Claude-Session: https://claude.ai/code/session_01Dxjadq3qkhKnqZR2b9WBFi

Co-authored-by: Claude <noreply@anthropic.com>
(cherry picked from commit 4c4ace8)
masenf pushed a commit that referenced this pull request Nov 11, 2026
…the train

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dxjadq3qkhKnqZR2b9WBFi
@masenf masenf added the release-train Issues found during agentic /prerelease-testing fanout, not necessarily validated bugs. label Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on deck PRs lined up to review / merge next release-train Issues found during agentic /prerelease-testing fanout, not necessarily validated bugs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants