Skip to content

Warn when an unkeyed rx.foreach item has lifecycle events or hooks - #7820

Merged
FarhanAliRaza merged 4 commits into
mainfrom
fix/foreach-lifecycle-without-key-warning
Nov 11, 2026
Merged

FarhanAliRaza merged 4 commits into
mainfrom
fix/foreach-lifecycle-without-key-warning

Name the field and page in the foreach index-key warning, skip consta…

4575706
Select commit
Loading
Failed to load commit list.
CodSpeed / CodSpeed Performance Analysis succeeded Nov 11, 2026 in 0s

Performance Gate Passed

2 warnings

⚠️ 17 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 1 benchmark with a significant change ran on different hardware

Its base and head results were measured on machines with a different CPU, core count or memory, so the change might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚡ 1 improved benchmark
✅ 150 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ test_route_matching[10] 53.6 µs 50.3 µs +6.54%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing fix/foreach-lifecycle-without-key-warning (4575706) with main (f0088e0)

Open in CodSpeed