Skip to content

fix: display fallback DataEditor cell values - #7823

Open
harsh21234i wants to merge 2 commits into
reflex-dev:mainfrom
harsh21234i:fix/7822-dataeditor-unsupported-type-fallback
Open

harsh21234i wants to merge 2 commits into
reflex-dev:mainfrom
harsh21234i:fix/7822-dataeditor-unsupported-type-fallback

Conversation

@harsh21234i

@harsh21234i harsh21234i commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fixes #7822

When a DataEditor column has an unsupported type, its text-cell fallback now displays the cell value instead of the column type. The raw cell data is unchanged.

Testing

  • 20 DataEditor and component-export tests passed locally. A temporary pandas stub was used because the pandas download stalled.

View guided diff

@harsh21234i
harsh21234i requested a review from a team as a code owner November 11, 2026 10:13

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

DataEditor fallback text cells now show their values instead of the column type.

  • Unsupported DataEditor columns show the cell value as text.

Reviews (3) · Last reviewed commit: "fix: harden unsupported DataEditor cell ..." · Reviewed by Greptile

@codspeed

codspeed Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 4.44%

1 warning

⚠️ 23 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

❌ 1 regressed benchmark
✅ 150 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ test_process_event_burst_independent_tokens[1] 2.7 ms 2.9 ms -4.44%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing harsh21234i:fix/7822-dataeditor-unsupported-type-fallback (9c15325) with main (2d71015)

Open in CodSpeed

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DataEditor fallback displays unsupported column type instead of cell value

1 participant