[masenf]

All Submissions:

• Have you followed the guidelines stated in CONTRIBUTING.md file?
• Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

• New feature (non-breaking change which adds functionality)
• This change requires a documentation update

Description

Stacked on #7724, which teaches form compilation that a control rendered by rx.form.control takes its rx.form.field's name.

rx.form.control only accepted rx.input and rx.debounce_input as its child, so a textarea or a low-level input, textarea or select could not take a form field's name and validation messages:

TypeError: Only Radix TextFieldRoot and DebounceInput are allowed as children of FormControl

Upstream Radix Form.Control composes with any native form control, and with nothing else: the Radix docs state that it cannot yet be composed with the other form primitives such as Checkbox and Select.

• FormControl.create now accepts every component backed by a native input, select or textarea, which covers rx.input, rx.text_area, rx.debounce_input, rx.el.input, rx.el.textarea and rx.el.select, and keeps rejecting the rest with a message that says to give those controls a name and place them under the root or field instead.
• A child is only rendered as the control with asChild, so as_child is set whenever a child is given, even over an explicit as_child=False; without it Radix renders an <input> with children, which React refuses and the page fails to render.
• The low-level form docs list what a Form Control renders and where the unsupported controls go.

Changes To Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Unit tests cover acceptance of each native control and the exact rejection message. The new Playwright test tests/integration/tests_playwright/test_radix_form_control.py runs a form with one field per accepted control, including a fully controlled input that compiles to DebounceInput, and checks that each control carries its field's name and the id its label points to, that a required textarea blocks submission and shows its rx.form.message, and that the submitted payload holds every value, with no page errors.

---

Generated by Claude Code

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The reviewed changes appear safe to merge.

Summary

rx.form.control now accepts native inputs, selects, and textareas, including the supported Reflex wrappers.

• Form controls can use native inputs, text areas, and selects as children.

No new actionable issues were found in the changes since the previous review. Tests were inspected, not run. No previous review threads were supplied.

_{Reviews (5) · Last reviewed commit: "fix(forms): render a form control's chil..." · Reviewed by Greptile}

[codspeed]

Merging this PR will improve performance by 5.69%

2 warnings

⚠️ 17 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 1 benchmark with a significant change ran on different hardware

Its base and head results were measured on machines with a different CPU, core count or memory, so the change might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚡ 1 improved benchmark
✅ 150 untouched benchmarks

Performance Changes

	Benchmark	BASE	HEAD	Efficiency
⚡	test_route_matching[1000]	50.7 µs	47.9 µs	+5.69%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing claude/form-control-children (16c8209) with main (8f1856f)}

[cubic-dev-ai]

1 issue found across 6 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="tests/integration/tests_playwright/test_radix_form_control.py">

<violation number="1" location="tests/integration/tests_playwright/test_radix_form_control.py:17">
P2: This test does not cover `rx.debounce_input`, which `rx.form.control` accepts. Add a `debounce_input` field, for example `form_field("debounced", rx.debounce_input(rx.el.input(default_value="debounced input")))`, and add it to `FIELD_NAMES` and the expected submitted dict. Otherwise the docstring's claim about every accepted control is not backed by the test.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic</sub>

[cubic-dev-ai]

2 issues found across 6 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/reflex-components-radix/src/reflex_components_radix/primitives/form.py">

<violation number="1" location="packages/reflex-components-radix/src/reflex_components_radix/primitives/form.py:20">
P2: `FormControl.create` rejects custom components that directly render a native `input`, `select`, or `textarea` because it checks only concrete class inheritance. Accept native-tag children in addition to the known wrappers so the advertised “component rendering” contract covers custom native controls.</violation>

<violation number="2" location="packages/reflex-components-radix/src/reflex_components_radix/primitives/form.py:20">
P2: `DebounceInput` is accepted without checking the control it wraps. `rx.debounce_input(rx.checkbox(on_change=...))` passes this check, even though `rx.checkbox` is a Radix control the rejection message says must be refused. Check the wrapped element's type, or reject `DebounceInput` children whose `element` is not a native control.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic</sub>