Release v1.7.6 - #231
Open
ashwgit wants to merge 1 commit into
Open
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis release updates the package metadata to version 1.7.6; the described commercial-marketplace-setup support was added in an earlier change and is not present in the supplied diff. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="setup.py" line_range="6" />
<code_context>
name='cloudpub',
description='Services for publishing products in cloud environments',
- version='1.7.5',
+ version='1.7.6',
keywords='stratosphere cloudpub cloudpublish',
author='Jonathan Gangi',
</code_context>
<issue_to_address>
**issue (broader_impact):** Publishing this package as version 1.7.6 does not add support for `commercial-marketplace-setup`: `RESOURCE_MAPING` still has no entry for that resource, so `Product._preprocess_json` raises `KeyError` when the API returns it.
**Triggers:** When a product resource tree contains `commercial-marketplace-setup`.
**Suggested fix:** Add the resource model and `RESOURCE_MAPING` entry, together with the corresponding service handling, before releasing version 1.7.6.
</issue_to_address>
### Comment 2
<location path="setup.py" line_range="6" />
<code_context>
name='cloudpub',
description='Services for publishing products in cloud environments',
- version='1.7.5',
+ version='1.7.6',
keywords='stratosphere cloudpub cloudpublish',
author='Jonathan Gangi',
</code_context>
<issue_to_address>
**nitpick:** The package metadata advertises 1.7.6, but `CHANGELOG.md` has no 1.7.6 entry or entry for the commercial-marketplace-setup support, so release documentation still identifies 1.7.5 as the latest release.
**Triggers:** When users or release tooling rely on `CHANGELOG.md` for the contents of version 1.7.6.
**Suggested fix:** Add a dated `1.7.6` changelog section describing the new resource type before publishing the release.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: setup.py:6
ashwgit
force-pushed
the
release_v1.7.6
branch
from
September 11, 2026 11:21
b24a561 to
1911e42
Compare
What's Changed
Add support for resource type commercial-marketplace-setup by @ashwgit in release-engineering#230
ashwgit
force-pushed
the
release_v1.7.6
branch
from
September 11, 2026 11:27
1911e42 to
6e6daf6
Compare
Collaborator
|
I would to create one more tiny change can it wait till Monday? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Summary by Sourcery
Release version 1.7.6 with support for commercial marketplace setup resources.
New Features:
Build:
Documentation: