Keep watch alive after rebuild errors - #8641
Open
fhammerschmidt wants to merge 3 commits into
Open
Conversation
fhammerschmidt
marked this pull request as ready for review
September 10, 2026 09:25
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
fhammerschmidt
force-pushed
the
fix/watch-rebuild-recovery
branch
from
September 10, 2026 10:58
26da9d5 to
38467bf
Compare
fhammerschmidt
changed the base branch from
master
to
fix/clean-invalid-projects
September 10, 2026 10:59
fhammerschmidt
added this pull request to stack #8642
September 10, 2026 10:59
fhammerschmidt
force-pushed
the
fix/watch-rebuild-recovery
branch
from
September 10, 2026 11:16
38467bf to
527e72a
Compare
fhammerschmidt
force-pushed
the
fix/watch-rebuild-recovery
branch
from
September 10, 2026 11:20
527e72a to
95cbeca
Compare
fhammerschmidt
force-pushed
the
fix/watch-rebuild-recovery
branch
from
September 10, 2026 11:40
95cbeca to
08c262a
Compare
fhammerschmidt
force-pushed
the
fix/watch-rebuild-recovery
branch
from
September 10, 2026 11:44
08c262a to
23913a4
Compare
fhammerschmidt
force-pushed
the
fix/watch-rebuild-recovery
branch
from
September 11, 2026 13:46
23913a4 to
4cc230a
Compare
fhammerschmidt
force-pushed
the
fix/watch-rebuild-recovery
branch
from
September 11, 2026 13:49
4cc230a to
784f83f
Compare
fhammerschmidt
force-pushed
the
fix/watch-rebuild-recovery
branch
from
September 11, 2026 14:03
784f83f to
bb678d0
Compare
fhammerschmidt
force-pushed
the
fix/watch-rebuild-recovery
branch
from
September 11, 2026 15:38
bb678d0 to
52e838b
Compare
fhammerschmidt
force-pushed
the
fix/watch-rebuild-recovery
branch
from
September 11, 2026 16:41
52e838b to
1e2469f
Compare
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
fhammerschmidt
force-pushed
the
fix/watch-rebuild-recovery
branch
from
September 11, 2026 20:24
a4a65f3 to
3e45f81
Compare
fhammerschmidt
removed this pull request from stack #8642
September 11, 2026 20:25
fhammerschmidt
changed the base branch from
fix/clean-invalid-projects
to
fix/watch-config-test-timeout
September 11, 2026 20:25
fhammerschmidt
added this pull request to stack #8650
September 11, 2026 20:25
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A config or source-layout change that made full rebuild initialization fail caused watch mode to panic and exit. Initialization errors now propagate through the build lock, are reported to the user, and leave the previous watch state available for recovery after a later valid change.
This was very easy to reproduce, just remove the trailing
}in arescript.jsonwhile the watcher runs, BOOM!