Skip to content

Keep watch alive after rebuild errors - #8641

Open
fhammerschmidt wants to merge 3 commits into
fix/watch-config-test-timeoutfrom
fix/watch-rebuild-recovery
Open

Keep watch alive after rebuild errors#8641
fhammerschmidt wants to merge 3 commits into
fix/watch-config-test-timeoutfrom
fix/watch-rebuild-recovery

Conversation

@fhammerschmidt

@fhammerschmidt fhammerschmidt commented Sep 10, 2026

Copy link
Copy Markdown
Member

A config or source-layout change that made full rebuild initialization fail caused watch mode to panic and exit. Initialization errors now propagate through the build lock, are reported to the user, and leave the previous watch state available for recovery after a later valid change.

This was very easy to reproduce, just remove the trailing } in a rescript.json while the watcher runs, BOOM!

@fhammerschmidt
fhammerschmidt marked this pull request as ready for review September 10, 2026 09:25
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T09:29:17.215570Z 26da9d5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@fhammerschmidt
fhammerschmidt force-pushed the fix/watch-rebuild-recovery branch from 26da9d5 to 38467bf Compare September 10, 2026 10:58
@fhammerschmidt
fhammerschmidt changed the base branch from master to fix/clean-invalid-projects September 10, 2026 10:59
@fhammerschmidt
fhammerschmidt added this pull request to stack #8642 September 10, 2026 10:59
@fhammerschmidt
fhammerschmidt force-pushed the fix/watch-rebuild-recovery branch from 38467bf to 527e72a Compare September 10, 2026 11:16
@fhammerschmidt
fhammerschmidt force-pushed the fix/watch-rebuild-recovery branch from 527e72a to 95cbeca Compare September 10, 2026 11:20
@fhammerschmidt
fhammerschmidt force-pushed the fix/watch-rebuild-recovery branch from 95cbeca to 08c262a Compare September 10, 2026 11:40
@fhammerschmidt
fhammerschmidt force-pushed the fix/watch-rebuild-recovery branch from 08c262a to 23913a4 Compare September 10, 2026 11:44
@fhammerschmidt
fhammerschmidt force-pushed the fix/watch-rebuild-recovery branch from 23913a4 to 4cc230a Compare September 11, 2026 13:46
@fhammerschmidt
fhammerschmidt force-pushed the fix/watch-rebuild-recovery branch from 4cc230a to 784f83f Compare September 11, 2026 13:49
@fhammerschmidt
fhammerschmidt force-pushed the fix/watch-rebuild-recovery branch from 784f83f to bb678d0 Compare September 11, 2026 14:03
@fhammerschmidt
fhammerschmidt force-pushed the fix/watch-rebuild-recovery branch from bb678d0 to 52e838b Compare September 11, 2026 15:38
@fhammerschmidt
fhammerschmidt force-pushed the fix/watch-rebuild-recovery branch from 52e838b to 1e2469f Compare September 11, 2026 16:41
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
@fhammerschmidt
fhammerschmidt force-pushed the fix/watch-rebuild-recovery branch from a4a65f3 to 3e45f81 Compare September 11, 2026 20:24
@fhammerschmidt
fhammerschmidt removed this pull request from stack #8642 September 11, 2026 20:25
@fhammerschmidt
fhammerschmidt changed the base branch from fix/clean-invalid-projects to fix/watch-config-test-timeout September 11, 2026 20:25
@fhammerschmidt
fhammerschmidt added this pull request to stack #8650 September 11, 2026 20:25
@pkg-pr-new

pkg-pr-new Bot commented Sep 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@8641

@rescript/belt

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/belt@8641

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@8641

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@8641

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@8641

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@8641

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@8641

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@8641

commit: 3e45f81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant