Repository navigation
Update text of Commitment Schemes, DBC, Opret and Tapret pages - #27
Open
MariJJhodl wants to merge 2 commits into
Open
MariJJhodl wants to merge 2 commits into
MariJJhodl wants to merge 2 commits into
Conversation
added 2 commits
November 3, 2026 13:12
Revise wording, grammar and collocations across the commitment layer pages. Use BIP-341 terminology consistently (Key Path Spend, Script Path Spend), fix opcode names (OP_PUSHBYTES_32, OP_PUSHBYTES_33), correct the tweak symbol in the first Tapret diagram, and update the anchor link in anchors.md to the renamed Tapret heading.
rgb-consensus hashes the 64-byte Tapret commitment script as a tapscript leaf (TapNodeHash::from_script with LeafVersion::TapScript in src/dbc/tapret/xonlypk.rs), both with and without a pre-existing script tree. Replace tH_BRANCH/TapBranch with tH_LEAF/TapLeaf, including leaf version and size, wherever the commitment itself is hashed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I revised the prose of the Commitment Schemes, Deterministic Bitcoin Commitments, Opret and Tapret pages, keeping the original structure.
Please check the second commit (52ba4f9) in particular. The pages hashed the Tapret commitment with the TapBranch tag (tH_BRANCH). In rgb-consensus, the commitment script is hashed as a tapscript leaf, both with and without a pre-existing script tree (
TapNodeHash::from_script(&script_commitment, LeafVersion::TapScript)insrc/dbc/tapret/xonlypk.rs). The commit replaces tH_BRANCH/TapBranch with tH_LEAF/TapLeaf, including leaf version and size, in the formula and in the five diagrams. The note in case b1 (branches and leaves use different tags) also relies on the commitment being a leaf.@St333p could you confirm the TapLeaf change? Let me know if everything is okay, thanks!