Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
St333p
requested changes
Nov 3, 2026
push_rgb_transition set each input's consumer separately, deserializing and re-serializing the contract's whole consumer map every time, which is quadratic in the number of inputs: with u16 inputs it takes hours. Pushing transitions one by one is quadratic in their number too: spending a UTXO with u16 allocations, each moved by its own one-input transition, takes well over 15 minutes. Add push_rgb_transitions, which checks a whole batch in memory and then reads and writes each contract's consumers once, decoding each transition already present once; on any error, a double spend included, the PSBT is left unchanged. It returns the number of new transitions. push_rgb_transition and rgb_embed now go through it.
rgb_bundles decoded a transition from the PSBT once per input it spends, which is quadratic in the number of inputs: committing a transition with u16 inputs took hours.
St333p
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.