Repository navigation
Conversation
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Rayman
marked this pull request as draft
July 9, 2026 08:57
Contributor
Author
|
I don't want to create a separate branch for kilted. So let's see if the new constructor can be backported. EDIT: It can't, so let's not merge this for now |
This fixes a deprecation warning.
Rayman
force-pushed
the
refactor/tf-listener-constructor
branch
from
October 23, 2026 14:36
d849239 to
c3a4858
Compare
Contributor
Author
|
30 days until kilted is EOL |
Member
|
I think you can safely drop kilted at this point. Just don’t run a kilted release again. Or, you can ifdef the different constructor uses based on rclcpp version. See Nav2 for an example for how we support multi-distributions on main with them :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a deprecation warning. See ros2/geometry2#714. This constructor is available in tf2_ros 0.45.0 or higher, so lyrical or newer.