Skip to content

workflow updates, keep-docs-updated, and typo-sweep - #766

Merged
aronatkins merged 4 commits into
mainfrom
aron-workflow-updates
Nov 19, 2026
Merged

aronatkins merged 4 commits into
mainfrom
aron-workflow-updates

Conversation

@aronatkins

Copy link
Copy Markdown
Contributor

nudged by #765.

@aronatkins
aronatkins requested a review from karawoo November 19, 2026 14:58
Comment thread inst/vendor/renv.R
lockfile$Python <- NULL
renv_lockfile_write(lockfile, file = file)
writef("- Deactived Python -- the lockfile has been updated.")
writef("- Deactivated Python -- the lockfile has been updated.")

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is our vendored copy, but benign. Already resolved in renv.
https://github.com/rstudio/renv/blob/f3da1726252846650cb926490c06e2a63db64bf4/R/use-python.R#L433

Comment thread R/lockfile-metadata.R Outdated
Comment on lines +5 to +6
#' Project's \code{packrat.lock} contains some metadata before packages
#' dependencies informations. The project's lockfile is created and updated
#' dependencies information. The project's lockfile is created and updated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is "packages dependencies" redundant here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's trying to say that the packrat.lock has two chunks: project-wide metadata, then per-package metadata.

I've pushed a slight wording change, but don't want to expand the scope much more.

@aronatkins
aronatkins merged commit 51ad1cb into main Nov 19, 2026
11 checks passed
@aronatkins
aronatkins deleted the aron-workflow-updates branch November 19, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants