Repository navigation
Arg::keepAlive can be ignored on exception #185
Description
Activity
If an exception is raised in
invokeNativeFunction/invokeNativeMethodthen there would be no result returned from either. So seems ok for return values marked as keepAlive since there is nothing to mark.As for args marked as keep alive, I am not sure what the right thing would be. The code could process those before invoking the function...but what if the function never got far enough to actually take ownership of the passed in arg? I guess better to call mark on it and be safe then not do it and possibly GC it on the Ruby side?
I'm also not sure what to do with it, probably just highlight the pitfall in the docs is OK. Usually this has no effect.
Another thing that crossed my mind is there no API
removeKeepAlive. For example, if you remove an item from a collection. Have you ran into that issue?No, I never needed that. Actually, I used
Arg::keepAliveonly in constructor and have never ran intokeepAliveon exception issue, too. I just noticed it can happen.
checkKeepAliveis called afterinvokeNativeFunction/invokeNativeMethod. So, imagine a native function that caches its argument and then throws an exception for some reason. In that caseNativeFunction<>::callwill handle the exception, butNativeFunction<>::operator()will fail to store the argument intokeepAlive_.It's not an issue for me, actually, but I think it's worth highlighting in the documentation or fixing it.