Skip to content

Add key mismatch tests and hardening - #81

Merged
raphjaph merged 2 commits into
masterfrom
key-mismatch-tests
Aug 16, 2026
Merged

raphjaph merged 2 commits into
masterfrom
key-mismatch-tests

Conversation

@raphjaph

@raphjaph raphjaph commented Aug 14, 2026 •

Copy link
Copy Markdown
Collaborator

This PR tries to harden by enforcing one invariant: A signature produced with a private key that doesn't correspond to the address must never be accepted, and should be rejected as early as possible.

  1. Hardening in sign.rs
  2. Test coverage

@raphjaph

Copy link
Copy Markdown
Collaborator Author

@aagbotemi could you give this a quick review?

@aagbotemi aagbotemi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4abd5c1

@raphjaph
raphjaph merged commit cefffc5 into master Aug 16, 2026
13 checks passed
@raphjaph
raphjaph deleted the key-mismatch-tests branch August 16, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants