Conversation
…`min` We have an assertion in `buf_encoder` whose purpose is to provide an early range-check to (hopefully) prod the compiler into eliding range checks inside a loop. But because we were asserting on the iterator's `size_hint` maximum, which might overstate the iterator's length, this extra assertion accidentally restricted what iterators could be used with the function. For the cases we can realistically expect optimizations, the minimum and maximum are the same, so just use the minimum instead. (Iterators are allowed to lie about their minimums, but at least when they do this they are misbehaving and it's reasonable that this would cause panics.)
Member
Author
|
On d1874c8 successfully ran local tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have an assertion in
buf_encoderwhose purpose is to provide an early range-check to (hopefully) prod the compiler into eliding range checks inside a loop.But because we were asserting on the iterator's
size_hintmaximum, which might overstate the iterator's length, this extra assertion accidentally restricted what iterators could be used with the function.For the cases we can realistically expect optimizations, the minimum and maximum are the same, so just use the minimum instead. (Iterators are allowed to lie about their minimums, but at least when they do this they are misbehaving and it's reasonable that this would cause panics.)
Fixes https://github.com/project-loupe/audit-hex-conservative/issues/3