Skip to content

Implement unlinkat to support fs::remove_dir_all - #5414

Open
programskillforverification wants to merge 1 commit into
rust-lang:masterfrom
programskillforverification:unix-unlinkat
Open

Implement unlinkat to support fs::remove_dir_all#5414
programskillforverification wants to merge 1 commit into
rust-lang:masterfrom
programskillforverification:unix-unlinkat

Conversation

@programskillforverification

@programskillforverification programskillforverification commented Oct 12, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Fix #5408

@rustbot rustbot added the S-waiting-on-review Status: Waiting for a review to complete label Oct 12, 2026
@programskillforverification
programskillforverification marked this pull request as draft October 13, 2026 08:26
@rustbot rustbot added S-waiting-on-author Status: Waiting for the PR author to address review comments and removed S-waiting-on-review Status: Waiting for a review to complete labels Oct 13, 2026
@rustbot

This comment has been minimized.

Sign in to view
RalfJung
RalfJung reviewed Oct 18, 2026
View reviewed changes
Comment thread src/shims/unix/fs.rs Resolved
RalfJung
RalfJung reviewed Oct 18, 2026
View reviewed changes
Comment thread tests/pass-dep/libc/libc-fs-with-isolation.rs Resolved
@programskillforverification

programskillforverification commented Oct 18, 2026

Copy link
Copy Markdown
Contributor Author

@RalfJung Dir on std is still under development. Could you add blocked label for this PR?

@RalfJung

RalfJung commented Oct 18, 2026

Copy link
Copy Markdown
Member

There is Dir::remove_file and Dir::remove_dir so I don't think this is blocked?

@programskillforverification

programskillforverification commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

There is Dir::remove_file and Dir::remove_dir so I don't think this is blocked?

My description is not accurate. Yes, the methods exist, so this is not blocked on missing API. The problem is a bug in them which make CI not pass: on Windows, Dir::remove_file and Dir::remove_dir follow symlinks, so they remove the link target and leave the link in place, while still returning Ok(()). I reported it as rust-lang/rust#164249.

@RalfJung

RalfJung commented Oct 19, 2026

Copy link
Copy Markdown
Member

on Windows, Dir::remove_file and Dir::remove_dir follow symlinks, so they remove the link target and leave the link in place, while still returning Ok(())

Oh yeah that is pretty wrong indeed.
Nice catch!

@RalfJung RalfJung added S-blocked-on-rust Status: Blocked on landing a Rust PR and removed S-waiting-on-author Status: Waiting for the PR author to address review comments labels Oct 19, 2026
@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-author Status: Waiting for the PR author to address review comments label Oct 23, 2026
@RalfJung RalfJung removed the S-blocked-on-rust Status: Blocked on landing a Rust PR label Nov 11, 2026
@RalfJung

RalfJung commented Nov 11, 2026

Copy link
Copy Markdown
Member

rust-lang/rust#164249 is fixed so this is no longer blocked.

@programskillforverification
programskillforverification marked this pull request as ready for review November 11, 2026 14:59
@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added S-waiting-on-review Status: Waiting for a review to complete and removed S-waiting-on-author Status: Waiting for the PR author to address review comments labels Nov 11, 2026
@programskillforverification
programskillforverification marked this pull request as draft November 11, 2026 15:25
@rustbot rustbot added S-waiting-on-author Status: Waiting for the PR author to address review comments and removed S-waiting-on-review Status: Waiting for a review to complete labels Nov 11, 2026
@RalfJung RalfJung mentioned this pull request Nov 11, 2026
Closed
@programskillforverification
programskillforverification marked this pull request as ready for review November 12, 2026 05:37
@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added S-waiting-on-review Status: Waiting for a review to complete and removed S-waiting-on-author Status: Waiting for the PR author to address review comments labels Nov 12, 2026
@programskillforverification

programskillforverification commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees

No one assigned

Labels

S-waiting-on-review Status: Waiting for a review to complete

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support unlinkat

3 participants

@programskillforverification @rustbot @RalfJung