Repository navigation
Conversation
bjorn3
reviewed
Sep 21, 2026
| run: | | ||
| sed -i 's/jit./#jit./' config.txt | ||
| sed -i 's/aot.powi_libcall_signature/#aot.powi_libcall_signature/' config.txt | ||
| sed -i 's/aot.simd-shuffle-array-index/#aot.simd-shuffle-array-index/' config.txt |
Member
There was a problem hiding this comment.
Why does this test need to be ignored for LLVM? It doesn't test any cg_clif specific things.
Contributor
Author
There was a problem hiding this comment.
I added the skip because test_llvm was failing when I opened the PR.Unlike aot.powi_libcall_signature,it is just a runpass for simd_shuffle with a [u32; N] index which LLVM should handle fine.
will undo.
Member
There was a problem hiding this comment.
If LLVM doesn't accept this, how does pathfinder use it then?
bjorn3
reviewed
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1583
pathfinder_simd passes
[u32; N]array literals tosimd_shuffleinstead of a SIMD u32 vector. Accept both forms when lowering the intrinsic.Test plan:
./y.sh test—aot.simd-shuffle-array-indexpasses