Skip to content

Identify BSD-like portions and Go notices in openssl-probe 0.2.2 #55

Closed as not planned

Description

@beefstew

For openssl-probe 0.2.2 (archive SHA-256
7e036b411754132fd6b74e94b74e9a13c5cf606fa93d1885c35860d3060820b1), the README
states that portions are covered by various BSD-like licenses, while the crate
supplies MIT and Apache license files. Could you identify:

  1. The exact files/portions covered by that qualification, their license texts
    and copyright holders
  2. Whether the 2017 README caveat
    is stale or covers material beyond the Go tables added by the merged
    PR 41 in 2025
  3. The Go revision/files used for those tables and the original notices that
    downstream users should preserve

The Rust source explicitly credits Go's crypto/x509/root_*.go, and PR 41
confirms combining Go data with existing candidates. We have preserved the
identified Go BSD-3-Clause license and author credits from a pinned comparison
snapshot, but do not assume that snapshot is the exact imported revision or
that Go accounts for the entire older caveat. An upstream clarification or
corrected notice would let downstream users retain the appropriate attribution.

Activity

  1. djc commented on Nov 2, 2026

    @djc
    Member

    The 2017 README caveat was added long before I (or any of the current maintainers) got involved, so we don't know why that was added. It is definitely independent of the Go tables added in #41. I don't know the Go revision used for those tables or, therefore, the notices that downstream users should preserve.

  2. beefstew commented on Nov 2, 2026

    @beefstew
    Author

    Understood, thanks; I'll guess that I'll make-do. I unleashed AI with ORT on an app that I'm writing and this is one of the last couple of unresolved license questions that came up.

  3. djc commented on Nov 2, 2026

    @djc
    Member

    Happy to take a PR if you have any suggestions.

  4. beefstew commented on Nov 2, 2026

    @beefstew
    Author

    Thanks—that helps. We see two separate questions:

    The old README wording: Our best guess is that the vague reference to “BSD-like licenses” was copied from a standard description. Rust’s README uses the same wording. That is a clue, not proof, so we wouldn’t remove it on that basis alone.

    The later Go contribution: The certificate-location lists added in #41 came partly from Go. Go’s BSD-3-Clause license requires preserving its copyright notice, license conditions, and disclaimer. It does not require identifying the exact Git revision used.

    A concrete improvement would be to add a LICENSE-THIRD-PARTY file with a section identifying the certificate-location tables adapted from Go. That section could include:

    • The complete Go LICENSE, lines 1–27, including its copyright notice, all three conditions, and disclaimer
    • These additional file-specific credits:
    Copyright 2015 The Go Authors. All rights reserved.
    Copyright 2018 The Go Authors. All rights reserved.
    

    The 2015 credit appears in the Linux, BSD, and Solaris source headers; the 2018 credit appears in the AIX header. Examples: Linux lines 1–3 and AIX lines 1–3.

    These links identify the snapshot we checked, not a claim that it was the revision originally copied. This would improve attribution for the known Go contribution without pretending to resolve what the older README wording meant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions