Repository navigation
Revert "feat(vscode): editable .vscode/mcp.json configuration source (#89)" - #92
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts
89ab637(the squash merge of #89) frommain.Why
#89 was merged while 6 Codex review threads were still unresolved, including one P1. The merge decision was made on an incomplete read: the task loop's query used
reviewThreads(first: 100)with no pagination, and the PR had 106 threads — so the six newest findings were never returned and every check reported "0 unresolved".Full audit of #89 (all pages, plus review bodies):
The unresolved findings
--allowAllDirs marker --no-allowAllDirsas--allowAllDirs marker, flipping the server from restricted to unrestricted directoriesconfigSource.ts:413configSource.ts:969commands.ts:830configSource.ts:249configSource.ts:943webview.ts:439Verification of the revert
tsc --noEmitclean, 400/400 unit tests passRe-landing
The feature will be re-landed as a fresh PR with all six findings fixed and reviewed before merge. The P1 fix is already written and CI-green on #91, which will be folded into that re-land rather than merged on its own.