Skip to content

Revert "feat(vscode): editable .vscode/mcp.json configuration source (#89)" - #92

Merged
s2005 merged 1 commit into
mainfrom
revert-89-autodetect-mcp-source
Aug 23, 2026
Merged

s2005 merged 1 commit into
mainfrom
revert-89-autodetect-mcp-source

Conversation

@s2005

@s2005 s2005 commented Aug 23, 2026

Copy link
Copy Markdown
Owner

Reverts 89ab637 (the squash merge of #89) from main.

Why

#89 was merged while 6 Codex review threads were still unresolved, including one P1. The merge decision was made on an incomplete read: the task loop's query used reviewThreads(first: 100) with no pagination, and the PR had 106 threads — so the six newest findings were never returned and every check reported "0 unresolved".

Full audit of #89 (all pages, plus review bodies):

Threads 106 total — 100 resolved, 6 unresolved
Unresolved P1 1
Unresolved P2 5
Unresolved P0 / P3 0

The unresolved findings

Sev Finding File
P1 Parse direct wcli0 arguments as one server argument list — a positional between a boolean and its negation split the arg list at the wrong place, so a no-op save rewrote --allowAllDirs marker --no-allowAllDirs as --allowAllDirs marker, flipping the server from restricted to unrestricted directories configSource.ts:413
P2 Keep valueless scalar flags ahead of following positionals configSource.ts:969
P2 Reject delimiters in edited transport hosts commands.ts:830
P2 Exclude attached negations from modeled suffix evidence configSource.ts:249
P2 Preserve valueless array flags before later positionals configSource.ts:943
P2 Reject incompatible concurrent launch-method changes webview.ts:439

Verification of the revert

  • Extension: tsc --noEmit clean, 400/400 unit tests pass
  • Server: 1089 passed / 24 skipped, all suites green

Re-landing

The feature will be re-landed as a fresh PR with all six findings fixed and reviewed before merge. The P1 fix is already written and CI-green on #91, which will be folded into that re-land rather than merged on its own.

…(auto-detect, load, save) (#89)"

This reverts commit 89ab637.
@s2005
s2005 merged commit ffec750 into main Aug 23, 2026
4 checks passed
@s2005
s2005 deleted the revert-89-autodetect-mcp-source branch August 23, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant