Skip to content

Pin the pdf-switch vs share-merge hook ordering #320

Description

@neuromechanist

From the epic #278 deep review (code pass). mlx_impl/core.py:2618-2623 documents an ordering dependency between the adaptive-PDF switch hook and the share_comps merge hook and honestly notes "no test here pins the hooks' relative order... a future accidental swap would not be caught." Torch has the same relative ordering. Per the no-untracked-TODO norm, this issue is that tracking record: add a cross-backend test pinning the order (or an in-fit assertion), or document why the order is actually inconsequential.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions