Repository navigation
Keep a fixed obs column order in from_scanpy - #1162
Merged
Merged
Conversation
Sample identifiers and covariates were deduplicated through a set, so the order of coda.obs columns depended on PYTHONHASHSEED. Use an order-preserving dict.fromkeys with sample identifiers first; values are unchanged.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1162 +/- ##
==========================================
+ Coverage 75.67% 75.69% +0.02%
==========================================
Files 55 55
Lines 8431 8431
==========================================
+ Hits 6380 6382 +2
+ Misses 2051 2049 -2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from_scanpydeduplicates sample identifiers and covariates order-preservingly instead of via a set, socoda.obscolumns come out in a fixed order independent ofPYTHONHASHSEED.Values are unchanged.