Repository navigation
Add date, time, and location to event schema and display - #149
Open
silaselisha wants to merge 1 commit into
Open
silaselisha wants to merge 1 commit into
silaselisha wants to merge 1 commit into
Conversation
Refs seattlejs#127 - Add optional startTime/endTime ("HH:mm", Seattle time) and a structured location (name, address, mapUrl) to SJSEvent - Add EventDetails component listing the event's date, time, and location; show it on homepage event cards and on event pages - Backfill venues for 2024 events
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #127
What this changes
Schema (
src/data/types.d.ts): adds optional fields toSJSEvent:startTime/endTime: 24h"HH:mm", Seattle timelocation:{ name, address?, mapUrl? }(replaces the unusedlocation?: string)Display: new
EventDetailscomponent lists the event'sstartTimeis set)mapUrland the address in parenthesesIt's shown on homepage event cards (
Event.astro) and replaces the two duplicated lists on/events/<id>(page and email views). RSVP on event pages works as before.Data: adds venues to the 2024 events in
events.json, taken from their descriptions and ti.to pages. January 2024 also gets its time (5:30pm–8pm, from its description).Things to know
/events/<id>used to show5:30pm - 8:30pmfor every event. It now shows the event's own time, so events withoutstartTimehave no ⏰ bullet.events.json. The latest entry is November 2024, so the homepage won't show these bullets until the next meetup is added.seattlejs-airtable-clionly mapsName,Date,LinkandDescriptionwhen it creates an event, and the Airtable Events table has no time or venue columns. New events need these fields added by hand until the base and the CLI are updated. Existing events keep them when the CLI updates them. I can follow up with a CLI PR once the column names are agreed.Testing
npm run check: 0 errors, 0 warningsnpm run buildand the Prettier check pass/events/january-2024(time + venue),/events/april-2024(venue + address),/events/september-2024(venue without address) and/events/may-2022(no new fields)