Skip to content

Fail-closed potfile validation - #67

Merged
crypt0rr merged 3 commits into
masterfrom
codex/fail-closed-potfile-validation
Aug 14, 2026
Merged

crypt0rr merged 3 commits into
masterfrom
codex/fail-closed-potfile-validation

Conversation

@crypt0rr

Copy link
Copy Markdown
Collaborator

Summary

  • Add fail-closed potfile validation before normal Hashcat execution.
  • Reject missing, non-regular, unreadable, and unwritable potfiles without creating or mutating them.
  • Preserve non-mutating dry-run behavior for a missing potfile.
  • Add focused validation coverage and update the README, version notes, and backlog.

Why

Normal startup previously attempted to create a missing potfile and continued even when creation failed. That allowed an invalid runtime configuration to reach later session or processor logic. The new startup gate reports the exact potfile problem and stops before Hashcat starts.

Validation

  • make test-smoke
  • make test-campaign
  • make lint
  • Bash coverage: 100.00% executable-line and function coverage; baseline satisfied

All tests use isolated fixtures and fake dependencies; no GPU, real Hashcat execution, network access, or developer-local configuration is required.

@crypt0rr crypt0rr self-assigned this Aug 14, 2026
@crypt0rr
crypt0rr marked this pull request as ready for review August 14, 2026 12:38
@crypt0rr
crypt0rr merged commit 382ffe1 into master Aug 14, 2026
4 checks passed
@crypt0rr
crypt0rr deleted the codex/fail-closed-potfile-validation branch August 14, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant