Run management server shutdown smoke test last - #230
Open
andrijapanicsb wants to merge 1 commit into
Open
andrijapanicsb wants to merge 1 commit into
andrijapanicsb wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test_ms_maintenance_and_safe_shutdown.pyintentionally shuts down a CloudStack management server.The test currently runs in the normal alphabetical smoke-test sequence. It assumes that previously submitted asynchronous jobs have completed before
triggerShutdownis called, but the Trillian cleanup process uses non-blocking CloudStack API operations.This creates a race condition:
service cloudstack-management startbefore the server has actually stopped.This is timing-dependent and is not related to management server startup performance.
In an observed run, a pending
DeleteNetworkCmdwaited 600 seconds for a network lock. The shutdown test timed out after 300 seconds, and the management server stopped shortly afterwards, leaving the rest of the suite without a working API endpoint.Change
Remove
test_ms_maintenance_and_safe_shutdown.pyfrom the normal test list and append it after all other smoke tests, including the existing host maintenance and host HA tests.Apply the same ordering in both the legacy smoke-test runner and the generic test runner.
Result
The test still runs and its failures remain visible in the final xUnit results, but an unsuccessful management server recovery can no longer invalidate the results of subsequent smoke tests.
This is an execution-ordering change only. The CloudStack test itself and its assertions are not modified.
Validation
test_ms_maintenance_and_safe_shutdown.pyis the final test file.git diff --checkpasses.