Conversation
johnslavik
requested changes
Feb 26, 2024
johnslavik
left a comment
johnslavik
left a comment
There was a problem hiding this comment.
Since you requested my review, here it is. I'll get back to some of my points when I have time, probably tomorrow.
| @@ -0,0 +1,170 @@ | |||
| """Script to generate the project's credits.""" | |||
There was a problem hiding this comment.
I'll refine typing here a bit, okay?
Co-authored-by: Bartosz Sławecki <github.armored767@passinbox.com>
Co-authored-by: Bartosz Sławecki <github.armored767@passinbox.com>
Co-authored-by: Bartosz Sławecki <github.armored767@passinbox.com>
Co-authored-by: Bartosz Sławecki <github.armored767@passinbox.com>
Co-authored-by: Bartosz Sławecki <github.armored767@passinbox.com>
Co-authored-by: Bartosz Sławecki <github.armored767@passinbox.com>
Co-authored-by: Bartosz Sławecki <github.armored767@passinbox.com>
Co-authored-by: Bartosz Sławecki <github.armored767@passinbox.com>
Co-authored-by: Bartosz Sławecki <github.armored767@passinbox.com>
Co-authored-by: Bartosz Sławecki <github.armored767@passinbox.com>
Co-authored-by: Bartosz Sławecki <github.armored767@passinbox.com>
Co-authored-by: Bartosz Sławecki <github.armored767@passinbox.com>
Co-authored-by: Bartosz Sławecki <github.armored767@passinbox.com>
Co-authored-by: Bartosz Sławecki <github.armored767@passinbox.com>
Co-authored-by: Bartosz Sławecki <github.armored767@passinbox.com>
Co-authored-by: Bartosz Sławecki <github.armored767@passinbox.com>
Co-authored-by: Bartosz Sławecki <github.armored767@passinbox.com>
Member
Author
|
Thank you so much for your review! Please note that even if I request one from you, you have zero obligation to review, and it will never be urgent (unless explicitly mentioned), OK 😊 ? I believe I have applied/addressed/commented everything! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very rough PR. Still lots of things to be done:
Design and implement bug report system.scripts/make, mergeMakefileinto it.It's OK if tasks and CI do not work in this PR, we can fix them later in other PRs. I just want the template to generate a correct file tree, that can then be installed using Basher, and called from the CLI or sourced in scripts/libraries.
Closes shellm-org/cookiecutter-shellm#1.