Skip to content

feat(rule-inventory): fail a PR whose deleted skill prose maps to no rule-inventory row (FAFF-1428) #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alechill merged 13 commits into from
Nov 5, 2026
Merged

feat(rule-inventory): fail a PR whose deleted skill prose maps to no rule-inventory row (FAFF-1428) #1182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ef0001f
docs(FAFF-1428): add spec for Fail an extraction PR when a deleted sk…
alechill Nov 4, 2026
98bb2d7
feat(rule-inventory): fail a PR whose deleted skill prose maps to no …
alechill Nov 4, 2026
43ed768
test: count rule-inventory in the tsconfig include and Linux rung-set…
alechill Nov 4, 2026
00faed8
test(rule-inventory): an unreadable config exits 2 (FAFF-1428)
alechill Nov 4, 2026
20a887c
fix(rule-inventory): close six escapes found in independent review (F…
alechill Nov 4, 2026
c578668
fix(rule-inventory): no failing git call ends in exit 0; mode-only ch…
alechill Nov 4, 2026
084dbad
fix(rule-inventory): read tree entries through ls-tree so a failing l…
alechill Nov 4, 2026
6222044
test(rule-inventory): a failed main-checkout probe exits 2 with the d…
alechill Nov 4, 2026
7c0e20d
refactor(rule-inventory): drop the config-location guard FAFF-1463 ma…
alechill Nov 4, 2026
023b175
test(rule-inventory): retitle the overlay test; collect every-call mi…
alechill Nov 5, 2026
64243be
chore(FAFF-1428): anchor run evidence
alechill Nov 5, 2026
0f7ea2a
test(rule-inventory): start every fixture without origin/HEAD on any …
alechill Nov 5, 2026
809873f
chore(FAFF-1428): anchor run evidence
alechill Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
495 changes: 495 additions & 0 deletions .faff/anchors/run-20261104-043908-graft-FAFF-1428/FAFF-1428/ac-checklist.json
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 12 additions & 0 deletions .faff/anchors/run-20261104-043908-graft-FAFF-1428/FAFF-1428/build-progress.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"schema_version": 1,
"faff_version": "0.44.0",
"issue": "FAFF-1428",
"build": {
"status": "complete",
"diff_hash": "7c89f968d59c4d33d4e9349004d5bc816617278d282fc160dda4a89262d95792",
"branch": "FAFF-1428-rule-inventory-check",
"pushed_at": "2026-11-05T04:30:48.962Z"
},
"updated_at": "2026-11-05T04:30:48.962Z"
}
8 changes: 8 additions & 0 deletions .faff/anchors/run-20261104-043908-graft-FAFF-1428/FAFF-1428/chain-head.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"run_id": "run-20261104-043908-graft-FAFF-1428",
"issue": "FAFF-1428",
"head_seq": 6,
"head_sha256": "a1921f1cd041c65ea65be8b579e98086c42b5b2de53580e4eb5e1d9c183e46e3",
"line_count": 7,
"schema_floor": 2
}
4 changes: 4 additions & 0 deletions .faff/anchors/run-20261104-043908-graft-FAFF-1428/FAFF-1428/commissaire/producer/pk.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"pk": "-----BEGIN PUBLIC KEY-----\nMCowBQYDK2VwAyEAeneVFe/XteOJKXLj4elrU+SKRykLHIIrOzYr05EAdL0=\n-----END PUBLIC KEY-----\n",
"pk_fingerprint": "63fb9792d84045accb7add6724d4dbb0c73941627e7e5246d46bf2e101bd9ac9"
}
25 changes: 25 additions & 0 deletions .faff/anchors/run-20261104-043908-graft-FAFF-1428/FAFF-1428/declared-effects.jsonl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{"schema":3,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":0,"ts":"2026-11-04T04:39:08.514Z","author":"commissaire","producer_id":"run-20261104-043908-graft-FAFF-1428","contract_revision":"faff-runner-v1","kind_of_entry":"admission","unit_id":"-","step":"admit","prev":"7edf13ff84671efe8bddedc5d97da3fcece561b33b8dec1a73b612e5c60e1de0","payload":{"producer_id":"run-20261104-043908-graft-FAFF-1428","contract_revision":"faff-runner-v1","admitted_scope":["merge","branch-delete","pr-create","push","label-write","file-write","tracker-write"],"pk_fingerprint":"63fb9792d84045accb7add6724d4dbb0c73941627e7e5246d46bf2e101bd9ac9","admitted_at":"2026-11-04T04:39:08.499Z"},"commissaire_sig":"snkoxWClnnpADFEhH6lll3avfsEniLiiCqiBYxP3v1mIiicnhI0ZDODe+Y/tQYsyIQZ2jmqBu4A8XMHVP7SPDw=="}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":1,"ts":"2026-11-04T04:39:38.622Z","kind_of_entry":"declare","issue":"FAFF-1428","step":"tracker-write","effect":{"kind":"tracker-write","target":"FAFF-1428:Todo->In Progress","reversible":true},"prev":"10e4f3bd9d000ddab7e7789b2fa99204db2038530d1fb11cc0973fc24162aab8"}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":2,"ts":"2026-11-04T04:39:38.679Z","kind_of_entry":"declare","issue":"FAFF-1428","step":"label-write","effect":{"kind":"label-write","target":"FAFF-1428:faff-claimed","reversible":true},"prev":"76633127c6c12293a5f7c06312dbdf63022eccddd3a83357cdc4da37d76ca54d"}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":3,"ts":"2026-11-04T04:39:48.891Z","kind_of_entry":"observe","issue":"FAFF-1428","step":"tracker-write","effect":{"kind":"tracker-write","target":"FAFF-1428:Todo->In Progress","reversible":true},"prev":"01262a3d2b51abc738b02008ed34501d4fcbb3ea96be1f95b2b752c833c5c04c"}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":4,"ts":"2026-11-04T04:39:48.947Z","kind_of_entry":"observe","issue":"FAFF-1428","step":"label-write","effect":{"kind":"label-write","target":"FAFF-1428:faff-claimed","reversible":true},"prev":"cbf44629fc760d3b68e83a0c3f0d1ba1a173d58bb687031689eb6601894280c0"}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":5,"ts":"2026-11-04T05:11:45.510Z","kind_of_entry":"declare","issue":"FAFF-1428","step":"push","effect":{"kind":"push","target":"FAFF-1428-rule-inventory-check","reversible":true},"prev":"88b4337317be5be2ca524a27c8d29af47a06a33df87dfb276efd8fd8fe170227"}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":6,"ts":"2026-11-04T05:11:48.052Z","kind_of_entry":"observe","issue":"FAFF-1428","step":"push","effect":{"kind":"push","target":"FAFF-1428-rule-inventory-check","reversible":true},"prev":"a8946ef5ff3a833138065c11a0bd1fa7ebbc1b573a541e110543a23bbe45e533"}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":7,"ts":"2026-11-04T05:31:40.938Z","kind_of_entry":"declare","issue":"FAFF-1428","step":"push","effect":{"kind":"push","target":"FAFF-1428-rule-inventory-check","reversible":true},"prev":"49f7920dd05634e4f43b4bbe50bf54995ed1f8e08def489d65b8424392a90701"}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":8,"ts":"2026-11-04T05:31:43.013Z","kind_of_entry":"observe","issue":"FAFF-1428","step":"push","effect":{"kind":"push","target":"FAFF-1428-rule-inventory-check","reversible":true},"prev":"0de3f33dd2a8491d7f40e57b009bafe13ac07dab30038d47689c29024c6a934f"}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":9,"ts":"2026-11-04T05:45:35.790Z","kind_of_entry":"declare","issue":"FAFF-1428","step":"push","effect":{"kind":"push","target":"FAFF-1428-rule-inventory-check","reversible":true},"prev":"63619f5de2d594703d4f570bb986125d3f2af07dcbae2690ff64329ca8a8f65f"}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":10,"ts":"2026-11-04T05:45:37.574Z","kind_of_entry":"observe","issue":"FAFF-1428","step":"push","effect":{"kind":"push","target":"FAFF-1428-rule-inventory-check","reversible":true},"prev":"e766ea31affc4af5fd00e9e5ef7cdfed3e27d8382fd6f324f2ac8b97391fda1d"}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":11,"ts":"2026-11-04T05:57:40.763Z","kind_of_entry":"declare","issue":"FAFF-1428","step":"push","effect":{"kind":"push","target":"FAFF-1428-rule-inventory-check","reversible":true},"prev":"1167dc8b014fdbce0b873d6022956d2ae6d8e30e2ef692f7df97b05b2b528824"}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":12,"ts":"2026-11-04T05:57:42.961Z","kind_of_entry":"observe","issue":"FAFF-1428","step":"push","effect":{"kind":"push","target":"FAFF-1428-rule-inventory-check","reversible":true},"prev":"af8935dab2e6841d89a919f7f5b9f38e66f21686f8a51352285466b62fc78166"}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":13,"ts":"2026-11-04T21:53:07.058Z","kind_of_entry":"declare","issue":"FAFF-1428","step":"push","effect":{"kind":"push","target":"FAFF-1428-rule-inventory-check","reversible":true},"prev":"3193be197fdb930e2e2992fd25b42b3684b1a3911b815e66acef815bede2dcbf"}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":14,"ts":"2026-11-04T21:53:09.884Z","kind_of_entry":"observe","issue":"FAFF-1428","step":"push","effect":{"kind":"push","target":"FAFF-1428-rule-inventory-check","reversible":true},"prev":"ebbd4471a49d7153d86f2566712739266206bb3040c0693b3c95bd7fddef45d3"}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":15,"ts":"2026-11-05T03:58:17.347Z","kind_of_entry":"declare","issue":"FAFF-1428","step":"push","effect":{"kind":"push","target":"FAFF-1428-rule-inventory-check","reversible":true},"prev":"54f3a089ead528b1c48d364d4cded51f4fc862d16bc9e29bd9ff922fbd168ede"}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":16,"ts":"2026-11-05T03:58:20.751Z","kind_of_entry":"observe","issue":"FAFF-1428","step":"push","effect":{"kind":"push","target":"FAFF-1428-rule-inventory-check","reversible":true},"prev":"08fb954999f53f6c6db31dfcf9ee6fb6fc759adf90210c33c3d509c819385722"}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":17,"ts":"2026-11-05T04:10:02.103Z","kind_of_entry":"declare","issue":"FAFF-1428","step":"push","effect":{"kind":"push","target":"FAFF-1428-rule-inventory-check","reversible":true},"prev":"490d71f061af7beab14097a62ddd8c845e6a8922174cc56fcd6596e4980abff3"}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":18,"ts":"2026-11-05T04:10:04.562Z","kind_of_entry":"observe","issue":"FAFF-1428","step":"push","effect":{"kind":"push","target":"FAFF-1428-rule-inventory-check","reversible":true},"prev":"790e1878205e4fabccb08c1138bf6e1b1b74a74bce898ab981c48872bb640447"}
{"schema":3,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":19,"ts":"2026-11-05T04:10:07.479Z","author":"producer","producer_id":"run-20261104-043908-graft-FAFF-1428","contract_revision":"faff-runner-v1","kind_of_entry":"declare","unit_id":"FAFF-1428","step":"pr-create","prev":"2b293795e1414e39e7dea52be57f0e025cdf10b57e88ea4be9aafc0c4012b51d","effect":{"kind":"pr-create","target":"main","reversible":true},"producer_hmac":"7d4596d8b09eefa0cec2fed37b9bbfbf05fafa738d0358d183f73149a093fa3b"}
{"schema":3,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":20,"ts":"2026-11-05T04:10:07.547Z","author":"producer","producer_id":"run-20261104-043908-graft-FAFF-1428","contract_revision":"faff-runner-v1","kind_of_entry":"effect-decision-request","unit_id":"FAFF-1428","step":"pr-create","prev":"1bc8c048ca7d8c3792622ba6e268a9c882a01da17240c5b96224c0486f9f1b3e","payload":{"effect":{"kind":"pr-create","target":"main"},"declared_ref":null,"level":"L2","attended":true,"holdout":"meets-spec"},"producer_hmac":"2a014827e8d2512e315ac793d7b9dd48610de7d993a2a0c43eea2a548e342216"}
{"schema":3,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":21,"ts":"2026-11-05T04:10:07.550Z","author":"commissaire","producer_id":"run-20261104-043908-graft-FAFF-1428","contract_revision":"faff-runner-v1","kind_of_entry":"effect-decision-verdict","unit_id":"FAFF-1428","step":"pr-create","prev":"156f6fdb7ec26522babb7f8c22847ff20d4017980f3b299e5e15d3d9308f1a7d","payload":{"request_seq":20,"verdict":"grant","reason":"all-legs-pass","effect":{"kind":"pr-create","target":"main"},"level":"L2","attended":true,"holdout":"meets-spec","level_policy":{"pass":true,"reason":"attended"},"pure_verdict":"grant","pure_reason":"all-legs-pass"},"commissaire_sig":"TbzFwieidoBAixpQ6TY8M1rUZbN7HZn2ti5xoMu8JKVkTsJ2jFgkeek0xGXqB5UkfNCVZjbWOv83DiW3gH31Dw=="}
{"schema":3,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":22,"ts":"2026-11-05T04:10:11.935Z","author":"producer","producer_id":"run-20261104-043908-graft-FAFF-1428","contract_revision":"faff-runner-v1","kind_of_entry":"observe","unit_id":"FAFF-1428","step":"pr-create","prev":"bf801c3191586e243b8cc268174ab06e474947811f8bfc2e4d89867d7d3cc2ce","effect":{"kind":"pr-create","target":"main","reversible":true},"producer_hmac":"8d081095b86a8af2ff98308e58bfbc583899077cefa04123de464a13248a48ed"}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":23,"ts":"2026-11-05T04:30:45.525Z","kind_of_entry":"declare","issue":"FAFF-1428","step":"push","effect":{"kind":"push","target":"FAFF-1428-rule-inventory-check","reversible":true},"prev":"8fdce545b610e02d911dc14a48e03e11d2c0aed3e7a4e6bf596c20f8130fff5f"}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":24,"ts":"2026-11-05T04:30:48.112Z","kind_of_entry":"observe","issue":"FAFF-1428","step":"push","effect":{"kind":"push","target":"FAFF-1428-rule-inventory-check","reversible":true},"prev":"40a93e05131ee5c12487334e9295780961981c42592c8c84602789b00edaf97b"}
8 changes: 8 additions & 0 deletions .faff/anchors/run-20261104-043908-graft-FAFF-1428/FAFF-1428/effects-chain-head.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"run_id": "run-20261104-043908-graft-FAFF-1428",
"issue": "FAFF-1428",
"head_seq": 24,
"head_sha256": "98b477a0313a9e19d48dac3c22bd774b4dbad147f70e75765ae204a5a0148e8e",
"line_count": 25,
"schema_floor": 2
}
7 changes: 7 additions & 0 deletions .faff/anchors/run-20261104-043908-graft-FAFF-1428/FAFF-1428/events.jsonl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":0,"ts":"2026-11-04T04:39:08.374Z","prev":"7edf13ff84671efe8bddedc5d97da3fcece561b33b8dec1a73b612e5c60e1de0","phase":"run","type":"ledger-write","data":{"ledger_sha256":"fde7669c508968c948c0805e2421b4d8aac5d80981e24c5169c06334930999bf"}}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":1,"ts":"2026-11-04T04:39:08.376Z","prev":"0e5f26d4b85429ab869fb22b8202507d057fdbe242f1ad3d675451a5de05bfdf","phase":"run","type":"run-start","data":{"faff_version":"0.44.0"}}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":2,"ts":"2026-11-04T04:39:08.381Z","prev":"ee6de914e69fe66959673cfb5b6683178a4d5f3ae93bc2ce4955f1cf94b86d95","phase":"run","type":"runner-identity","data":{"github_login":null,"github_login_source":"unresolved","credential_source":"ambient","credential_unresolved":false,"verified":false}}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":3,"ts":"2026-11-04T05:16:48.629Z","prev":"f08cb502351d5ac3a8d09b5efc211430dd11b3b2641c6dd11293de6c0826e619","phase":"run","type":"ledger-write","data":{"ledger_sha256":"22852bcb808fd8ce8af99afbe6b2baefb9aaf40a5b5720ff48e47dd2bb45bea6"}}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":4,"ts":"2026-11-04T22:04:34.388Z","prev":"1b1de5e7292f72fe594f9127b5406ffe261b1e5fa9713bb3308517d0d0609e84","phase":"run","type":"ledger-write","data":{"ledger_sha256":"22852bcb808fd8ce8af99afbe6b2baefb9aaf40a5b5720ff48e47dd2bb45bea6"}}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":5,"ts":"2026-11-05T04:06:10.529Z","prev":"958ce6ec24f6e44274393cc19a52c73499bff0887f50078e9ecf97747a1f35e2","phase":"run","type":"ledger-write","data":{"ledger_sha256":"22852bcb808fd8ce8af99afbe6b2baefb9aaf40a5b5720ff48e47dd2bb45bea6"}}
{"schema":2,"run_id":"run-20261104-043908-graft-FAFF-1428","seq":6,"ts":"2026-11-05T04:39:37.218Z","prev":"7868e81c68853ffbb5681f10a6083b0c70d88986afb4e72075dac68a2d716c94","phase":"run","type":"ledger-write","data":{"ledger_sha256":"22852bcb808fd8ce8af99afbe6b2baefb9aaf40a5b5720ff48e47dd2bb45bea6"}}
Loading
Loading