Repository navigation
Conversation
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
SqrtandSqrtRound.SqrtRound(places)returns the square root rounded half away from zero toplacesdigits after the decimal point, likeDivRound. The result is always correctly rounded.Sqrt()usesDivisionPrecision, likeDiv.It runs
big.Int.Sqrton the scaled coefficient and rounds once, so there are no loops in our code. That's about 4–12x faster than going throughPowWithPrecision(0.5), for example 0.25 µs instead of 3.1 µs forsqrt(2).Checked against
big.Floaton 30k cases, plus a property test in the repo. Builds on Go 1.10.Replaces #393, #130 and #112. #130 and #112 give wrong digits, and #393 panics on negative numbers and is slower.