Repository navigation
fix: ExpHullAbrham returns the requested number of significant figures for large inputs - #470
Merged
Merged
Conversation
…s for large inputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExpHullAbrhamraises its working precision for large inputs, but it also rounded the result to that raised precision, so it returned more significant figures than asked. For example,exp(23.31)at precision 1 returned13000000000instead of10000000000, andexp(50)at precision 2 returned5.18e21instead of5.2e21.It now rounds to the requested precision, at least 1, so precision 0 behaves as before.
Checked against
expcomputed withbig.Floatat 600 bits: none of 33,759 cases returns extra digits anymore. Follow-up to #429.