Repository navigation
fix: reject overflowing division precision - #472
Merged
mwoss merged 2 commits intoOct 18, 2026
Merged
Conversation
Signed-off-by: Yusuf Efe <120668197+yuefdev@users.noreply.github.com>
Move the test next to the other overflow panic tests and use didPanic.
Member
|
Thanks, good catch! I pushed a small cleanup on top: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject
math.MinInt32before negating division precision. Negating this value as anint32wraps back to itself, so the existing exponent check can miss the overflow and return an incorrect non-zero quotient.The regression uses
New(1, math.MinInt32)divided by one, without constructing a huge number. BothQuoRemandDivRoundfail the regression before the fix. The adjacent valid precision bounds are checked too.Focused division tests,
go vet ./...and formatting pass.