Move the gnarly git aliases into bin scripts

[slifty]

The [alias] block had grown several aliases that were single, very long
lines of escaped shell — effectively unreadable and unreviewable. Each one
moves into bin/, where it gets real control flow, comments and usage docs,
and leaves a one-line alias behind.

alias	now
up	bin/git-up
cleanup	bin/git-cleanup
brebase	bin/git-brebase
edit	bin/git-edit
sync	bin/git-sync

plog, cremit, fpush and track are already readable one-liners and are
left alone.

The aliases point at ~/.dotfiles/bin/... rather than relying on bin/ being
on $PATH, so they keep working from a minimal environment such as a GUI git
client.

Behaviour changes

Each extraction was diffed against the old alias by running both against
identical throwaway repos. Three deliberate differences:

• git edit raised its stash flag before taking the stash, so aborting in
  that window could git stash drop an unrelated stash. Our copy had drifted
  from the source gist,
  which has these the other way round; restored to match.
• git edit now exits non-zero when it aborts. It previously returned the
  status of its own cleanup, which was usually 0.
• git sync's "could not determine default branch" check could never fire —
  it tested the exit status of the sed ending a pipeline rather than the
  symbolic-ref feeding it. Against an upstream with no default branch it got
  as far as checking out a branch named sync/<timestamp>- and failing to merge
  <remote>/. The intended error now actually comes out.

git cleanup matches protected branch names as substrings, so a merged branch
named devops is spared along with dev. That is preserved as-is rather than
tightened, since the command deletes branches and the current behaviour errs
towards keeping them. It is commented in the script.

Also fixed

• system/install.sh was the one install script with no shebang, no set -e
  and no shared functions, and its bare ln failed on every re-bootstrap once
  $HOME/bin existed. Linking is conditional now, and the apps it opens are
  guarded so a missing cask warns rather than halting under set -e.
• An indented code block inside a list item in claude/config/CLAUDE.md never
  reached a prettier fixed point, gaining a couple of spaces per pass, so
  npm run format dirtied the file and npm run lint failed on it regardless.
  Fencing the block settles it. This was failing CI on main already.

5a78435 predates this work and rides along on the branch.

---

🤖 Generated with Claude Code

Session: d019263c-0e35-4452-b1c2-f685d76d5c18

[Copilot]

🟡 Changes recommended

The new bin/git-cleanup and updated system/install.sh have confirmed failure modes (macOS xargs empty-input behavior; existing non-symlink $HOME/bin) that can break normal usage under set -e.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR refactors several complex git aliases out of git/gitconfig.symlink into dedicated bin/git-* scripts to improve readability and maintainability, while also hardening an install script and fixing a markdown formatting issue that was breaking Prettier/CI.

Changes:

• Extracted git up, git cleanup, git brebase, git edit, and git sync into standalone bin/ scripts and updated aliases to call them.
• Updated system/install.sh to follow the repo’s standard install-script pattern (shebang, set -e, shared functions.sh), make linking idempotent, and guard open calls.
• Fixed markdown code-block formatting in claude/config/CLAUDE.md and adjusted the global gitignore list.

File summaries

File	Description
system/install.sh	Adds standard script boilerplate and makes bin-linking + app-opening more robust/idempotent.
git/gitignore.symlink	Removes .java-version from the global ignore list.
git/gitconfig.symlink	Replaces long shell-escaped aliases with calls to ~/.dotfiles/bin/git-* scripts.
claude/config/CLAUDE.md	Switches to fenced code block to stabilize Prettier formatting.
bin/git-up	New script implementing the git up behavior with clearer control flow and messaging.
bin/git-sync	New script implementing the git sync behavior with corrected default-branch detection.
bin/git-edit	New script implementing the git edit workflow with explicit abort handling and non-zero exit on abort.
bin/git-cleanup	New script implementing the git cleanup branch-deletion workflow.
bin/git-brebase	New script implementing the git brebase interactive-rebase workflow.

Review details

• Files reviewed: 4/9 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[slifty]

Good catch, fixed in b8711e3.

Worth noting the failure is quieter than described: ln -ns against an existing directory doesn't fail at all. It creates the link inside it as $HOME/bin/bin, exits 0, and set -e never fires — so bootstrap reports success while the dotfiles bin is not where path.zsh expects it. Only the plain-file case exits non-zero.

Existing paths now move to bin.backup before linking, following the pattern in maestral/install.sh, with a collision guard so an existing backup is an error rather than a second clobber. Verified across four states: no bin, already linked, real directory, real file.

🤖 Generated with Claude Code

Session: d019263c-0e35-4452-b1c2-f685d76d5c18

[slifty]

On the other half of the review — the bin/git-cleanup xargs concern doesn't reproduce on macOS.

BSD xargs does not run the command on empty input (GNU's -r behaviour is the default here), and although grep -Ev exits 1 when it filters everything out, the pipeline's status is xargs's, since pipefail is not set. Measured:

$ printf '' | xargs -n 1 echo RAN     # prints nothing, exit 0
$ git branch --merged | grep -Ev '...' ; echo $?    # 1
$ git branch --merged | grep -Ev '...' | xargs -n 1 git branch -d ; echo $?    # 0

Running git cleanup in a repo with nothing to delete exits 0 under set -e. No change made.

🤖 Generated with Claude Code

Session: d019263c-0e35-4452-b1c2-f685d76d5c18