docs/migrator: Update schema-drift page with current migrator output - #1885
Open
marcleblanc2 wants to merge 3 commits into
Open
docs/migrator: Update schema-drift page with current migrator output#1885marcleblanc2 wants to merge 3 commits into
marcleblanc2 wants to merge 3 commits into
Conversation
The lsif_data_docs_search_private_delete example showed migrator reporting a space-vs-newline difference in a function definition. Since sourcegraph/sourcegraph f9b273e (May 2023), function definitions are whitespace-normalized before comparison, so this drift can no longer be reported. The example also used the old 'replace the function definition' wording and the old ❌ prefix, and its pasted output was hard-wrapped mid-token. Amp-Thread-ID: https://ampcode.com/threads/T-01a08426-e0ec-71d9-a4b9-bcf3deaa2890 Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- EmojiFailure is now ' ⨯' (was ❌); migrator banner uses ✱ - Column drift with a targeted fix now says 'alter the column' and prints only the ALTER statement, not a go-cmp struct diff - Drift command prints a single 'Drift detected!' preamble - Upgrade-time hint now links to the schema-drift docs page - Unwrap hard-wrapped SQL so statements match what migrator prints Amp-Thread-ID: https://ampcode.com/threads/T-01a08426-e0ec-71d9-a4b9-bcf3deaa2890 Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
changed the title
Amp-Thread-ID: https://ampcode.com/threads/T-01a08426-e0ec-71d9-a4b9-bcf3deaa2890 Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
changed the title
marcleblanc2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings
docs/self-hosted/updates/migrator/schema-drift.mdxin line with whatmigratorprints today (internal/database/migration/drift/andlib/output/emoji.goin sourcegraph/sourcegraph).Removed the
lsif_data_docs_search_private_deleteexample:normalizeFunctioncollapses all whitespace in function definitions before comparison, so a space-vs-newline difference is no longer drift.cmp.Diffoutput was hard-wrapped mid-token ($functio"/"n$), which is also what produced thefunctiofragment in the spellcheck word list.Refreshed the remaining examples:
EmojiFailureis now⨯(was❌); the migrator banner uses✱.Suggested action: alter the column.and prints only theALTERstatement, no go-cmp struct diff (compare_columns.go+ColumnDescription.AlterToTarget). The oldchange the column nullability constraintandreplace the function definitionwordings were dropped in sourcegraph/sourcegraph@5fbbcdafd46cda11da80dcc120d0f2a39e2be84d (#50207).⨯ Drift detected!preamble before the summaries (drift/util.go).multiversion/drift.go).Test plan
-skip-drift-checkparagraph.Amp threads