Add support for Jedis readOnlyForRedisClusterReplicas - #3445
Closed
hunseonglee wants to merge 1 commit into
Closed
hunseonglee wants to merge 1 commit into
hunseonglee wants to merge 1 commit into
Conversation
Expose Jedis' readOnlyForRedisClusterReplicas client option through JedisClientConfiguration so that read operations can be served by Redis Cluster replica nodes. The flag is propagated to the underlying DefaultJedisClientConfig when the connection factory creates its client configuration. Closes spring-projects#2972 Signed-off-by: seonghun lee <harrisleesh@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
|
We talked about that and decided that we don't need a dedicated API for that, as the customizer makes this "nice enough". Thanks for the PR anyway! |
mhalbritter
added
status: declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes Jedis'
readOnlyForRedisClusterReplicasclient option throughJedisClientConfiguration, as discussed in #2972 — the feature is now available in the released Jedis version this project builds against (8.0.1 providesDefaultJedisClientConfig.Builder#readOnlyForRedisClusterReplicas()).Changes:
JedisClientConfiguration: newisReadOnlyForRedisClusterReplicas()(defaultfalse) and builder methodreadOnlyForRedisClusterReplicas(), following the existing builder style.DefaultJedisClientConfiguration: carries the new flag.JedisConnectionFactory#createClientConfig: propagates the flag to the underlyingDefaultJedisClientConfigbuilder (before the client config customizer, so a customizer can still override).JedisClientConfig(@Test // GH-2972).I kept the interface method as a
defaultreturningfalseto stay compatible with externalJedisClientConfigurationimplementors — happy to make it abstract instead if you prefer, givengetProtocol()took that route.Closes #2972