Repository navigation
Conversation
Author
|
Ready for review: mergeable, current with \main\ (0 commits behind), no outstanding review comments. Verified locally on Windows: \�un run lint, \�un run format:check, \�un run typecheck\ pass; \�un test test/drafts.test.ts\ 18 pass. CI: run 41068799467 is \�ction_required\ -- GitHub requires a maintainer to approve workflow runs for fork PRs, so the jobs never started and I cannot re-trigger them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #175: thread-reply drafts were landing in the channel's main message box instead of the thread's reply box.
The root cause: createDraft was sending is_from_composer: true, but the official Slack client sends alse when saving a draft from a channel/thread message box.
Changed to is_from_composer: false and updated the test accordingly.