Repository navigation
Conversation
…efox profile check
w21180239
force-pushed
the
fix-windows-firefox-error
branch
from
November 4, 2026 12:01
9ec69dc to
318b4f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Fix Windows Firefox profile extraction error
Problem
On Windows,
agent-slackCLI commands throwFirefox extraction is not supported on win32.when:--workspaceselector that doesn't match any configured workspace incredentials.json.This happens because
src/auth/firefox-profile.ts'sgetFirefoxBaseDir()unconditionally throws onwin32instead of gracefully returning a Windows-compatible path or skipping.Root cause
When a workspace selector isn't resolved from
credentials.json, the CLI falls back to browser/desktop credential extraction pipelines (extractFromSlackDesktop,extractFromChrome,extractFromBrave,extractFromFirefox). TheextractFromFirefoxcall invokeslistProfileCandidates(), which callsgetFirefoxBaseDir(). On Windows, this function currently throws an error, crashing the entire CLI before it can fall through to the other browsers (or return null/empty credentials as expected).Fix
Replace the unconditional
throwwith a Windows-compatible path return ingetFirefoxBaseDir(). This allows Firefox profile detection to either find a valid Firefox installation on Windows (if present) or return null fromlistProfileCandidates()when no profiles exist, enabling the fallback chain to continue gracefully to other auth sources.Testing
Reproduction