1.2.0 - #65
Merged
Merged
1.2.0#65
Conversation
…heck
status-go's Docker build context has no .git, so its embedded version is
empty and /health answers {}. Pass the ref being built through the existing
build_flags build arg as an -ldflags -X override, so the container reports
what it was built from without any status-go change.
The healthcheck passed the whole command as one argv entry, so Docker looked
for an executable literally named "curl http://0.0.0.0:8080/health" and the
container never became healthy.
- Decrease RPC calls so `status-im/status-go` does not crash during many calls at once. If the user does not have privileges to send messages in the channel, a custom error will be raised
nickninov
added
bug
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: