Skip to content

test: migrate stats/base/snanstdev to ULP-based assertions #15216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 2 commits into from
Sep 15, 2026
Merged

test: migrate stats/base/snanstdev to ULP-based assertions #15216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc0cdf2
test: migrate `stats/base/snanstdev` to ULP-based assertions
claude Sep 14, 2026
bf2a6ca
Apply batched suggestions from code review
kgryte Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions lib/node_modules/@stdlib/stats/base/snanstdev/test/test.ndarray.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,9 @@
var tape = require( 'tape' );
var floor = require( '@stdlib/math/base/special/floor' );
var sqrt = require( '@stdlib/math/base/special/sqrt' );
var abs = require( '@stdlib/math/base/special/abs' );
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
var EPS = require( '@stdlib/constants/float32/eps' );
var isAlmostSameValuef = require( '@stdlib/number/float32/base/assert/is-almost-same-value' );
var Float32Array = require( '@stdlib/array/float32' );
var snanstdev = require( './../lib/ndarray.js' );

Expand All @@ -46,8 +45,6 @@ tape( 'the function has an arity of 5', function test( t ) {

tape( 'the function calculates the population standard deviation of a strided array (ignoring `NaN` values)', function test( t ) {
var expected;
var delta;
var tol;
var x;
var v;
var i;
Expand All @@ -56,17 +53,13 @@ tape( 'the function calculates the population standard deviation of a strided ar

v = snanstdev( x.length, 0, x, 1, 0 );
expected = float64ToFloat32( sqrt( 53.5/(x.length-1) ) );
delta = abs( v - expected );
tol = 1.0 * EPS * abs( expected );
t.strictEqual( delta <= tol, true, 'within tolerance. Actual: '+v+'. E: '+expected+'. tol: '+tol+'. 螖: '+delta+'.' );
t.strictEqual( isAlmostSameValuef( v, expected, 1 ), true, 'returns expected value' );

x = new Float32Array( [ 1.0, NaN, NaN, -2.0, NaN, -4.0, NaN, 5.0, NaN, 0.0, 3.0, NaN ] ); // eslint-disable-line max-len

v = snanstdev( x.length, 0, x, 1, 0 );
expected = float64ToFloat32( sqrt( 53.5/(x.length-6) ) );
delta = abs( v - expected );
tol = 1.0 * EPS * abs( expected );
t.strictEqual( delta <= tol, true, 'within tolerance. Actual: '+v+'. E: '+expected+'. tol: '+tol+'. 螖: '+delta+'.' );
t.strictEqual( isAlmostSameValuef( v, expected, 1 ), true, 'returns expected value' );

x = new Float32Array( [ -4.0, NaN ] );

Expand Down
13 changes: 3 additions & 10 deletions lib/node_modules/@stdlib/stats/base/snanstdev/test/test.ndarray.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,9 @@
var resolve = require( 'path' ).resolve;
var tape = require( 'tape' );
var floor = require( '@stdlib/math/base/special/floor' );
var abs = require( '@stdlib/math/base/special/abs' );
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
var EPS = require( '@stdlib/constants/float32/eps' );
var isAlmostSameValuef = require( '@stdlib/number/float32/base/assert/is-almost-same-value' );
var sqrt = require( '@stdlib/math/base/special/sqrt' );
var Float32Array = require( '@stdlib/array/float32' );
var tryRequire = require( '@stdlib/utils/try-require' );
Expand Down Expand Up @@ -55,8 +54,6 @@ tape( 'the function has an arity of 5', opts, function test( t ) {

tape( 'the function calculates the population standard deviation of a strided array (ignoring `NaN` values)', opts, function test( t ) {
var expected;
var delta;
var tol;
var x;
var v;
var i;
Expand All @@ -65,17 +62,13 @@ tape( 'the function calculates the population standard deviation of a strided ar

v = snanstdev( x.length, 0, x, 1, 0 );
expected = float64ToFloat32( sqrt( 53.5/(x.length-1) ) );
delta = abs( v - expected );
tol = 1.0 * EPS * abs( expected );
t.strictEqual( delta <= tol, true, 'within tolerance. Actual: '+v+'. E: '+expected+'. tol: '+tol+'. 螖: '+delta+'.' );
t.strictEqual( isAlmostSameValuef( v, expected, 1 ), true, 'returns expected value' );

x = new Float32Array( [ 1.0, NaN, NaN, -2.0, NaN, -4.0, NaN, 5.0, NaN, 0.0, 3.0, NaN ] ); // eslint-disable-line max-len

v = snanstdev( x.length, 0, x, 1, 0 );
expected = float64ToFloat32( sqrt( 53.5/(x.length-6) ) );
delta = abs( v - expected );
tol = 1.0 * EPS * abs( expected );
t.strictEqual( delta <= tol, true, 'within tolerance. Actual: '+v+'. E: '+expected+'. tol: '+tol+'. 螖: '+delta+'.' );
t.strictEqual( isAlmostSameValuef( v, expected, 1 ), true, 'returns expected value' );

x = new Float32Array( [ -4.0, NaN ] );

Expand Down
13 changes: 3 additions & 10 deletions lib/node_modules/@stdlib/stats/base/snanstdev/test/test.snanstdev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,9 @@

var tape = require( 'tape' );
var floor = require( '@stdlib/math/base/special/floor' );
var abs = require( '@stdlib/math/base/special/abs' );
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
var EPS = require( '@stdlib/constants/float32/eps' );
var isAlmostSameValuef = require( '@stdlib/number/float32/base/assert/is-almost-same-value' );
var sqrt = require( '@stdlib/math/base/special/sqrt' );
var Float32Array = require( '@stdlib/array/float32' );
var snanstdev = require( './../lib/snanstdev.js' );
Expand All @@ -46,8 +45,6 @@ tape( 'the function has an arity of 4', function test( t ) {

tape( 'the function calculates the population standard deviation of a strided array (ignoring `NaN` values)', function test( t ) {
var expected;
var delta;
var tol;
var x;
var v;
var i;
Expand All @@ -56,17 +53,13 @@ tape( 'the function calculates the population standard deviation of a strided ar

v = snanstdev( x.length, 0, x, 1 );
expected = float64ToFloat32( sqrt( 53.5/(x.length-1) ) );
delta = abs( v - expected );
tol = 1.0 * EPS * abs( expected );
t.strictEqual( delta <= tol, true, 'within tolerance. Actual: '+v+'. E: '+expected+'. tol: '+tol+'. 螖: '+delta+'.' );
t.strictEqual( isAlmostSameValuef( v, expected, 1 ), true, 'returns expected value' );

x = new Float32Array( [ 1.0, NaN, NaN, -2.0, NaN, -4.0, NaN, 5.0, NaN, 0.0, 3.0, NaN ] ); // eslint-disable-line max-len

v = snanstdev( x.length, 0, x, 1 );
expected = float64ToFloat32( sqrt( 53.5/(x.length-6) ) );
delta = abs( v - expected );
tol = 1.0 * EPS * abs( expected );
t.strictEqual( delta <= tol, true, 'within tolerance. Actual: '+v+'. E: '+expected+'. tol: '+tol+'. 螖: '+delta+'.' );
t.strictEqual( isAlmostSameValuef( v, expected, 1 ), true, 'returns expected value' );

x = new Float32Array( [ -4.0, NaN ] );

Expand Down
13 changes: 3 additions & 10 deletions lib/node_modules/@stdlib/stats/base/snanstdev/test/test.snanstdev.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,9 @@
var resolve = require( 'path' ).resolve;
var tape = require( 'tape' );
var floor = require( '@stdlib/math/base/special/floor' );
var abs = require( '@stdlib/math/base/special/abs' );
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
var EPS = require( '@stdlib/constants/float32/eps' );
var isAlmostSameValuef = require( '@stdlib/number/float32/base/assert/is-almost-same-value' );
var sqrt = require( '@stdlib/math/base/special/sqrt' );
var Float32Array = require( '@stdlib/array/float32' );
var tryRequire = require( '@stdlib/utils/try-require' );
Expand Down Expand Up @@ -55,8 +54,6 @@ tape( 'the function has an arity of 4', opts, function test( t ) {

tape( 'the function calculates the population standard deviation of a strided array (ignoring `NaN` values)', opts, function test( t ) {
var expected;
var delta;
var tol;
var x;
var v;
var i;
Expand All @@ -65,17 +62,13 @@ tape( 'the function calculates the population standard deviation of a strided ar

v = snanstdev( x.length, 0, x, 1 );
expected = float64ToFloat32( sqrt( 53.5/(x.length-1) ) );
delta = abs( v - expected );
tol = 1.0 * EPS * abs( expected );
t.strictEqual( delta <= tol, true, 'within tolerance. Actual: '+v+'. E: '+expected+'. tol: '+tol+'. 螖: '+delta+'.' );
t.strictEqual( isAlmostSameValuef( v, expected, 1 ), true, 'returns expected value' );

x = new Float32Array( [ 1.0, NaN, NaN, -2.0, NaN, -4.0, NaN, 5.0, NaN, 0.0, 3.0, NaN ] ); // eslint-disable-line max-len

v = snanstdev( x.length, 0, x, 1 );
expected = float64ToFloat32( sqrt( 53.5/(x.length-6) ) );
delta = abs( v - expected );
tol = 1.0 * EPS * abs( expected );
t.strictEqual( delta <= tol, true, 'within tolerance. Actual: '+v+'. E: '+expected+'. tol: '+tol+'. 螖: '+delta+'.' );
t.strictEqual( isAlmostSameValuef( v, expected, 1 ), true, 'returns expected value' );

x = new Float32Array( [ -4.0, NaN ] );

Expand Down