Repository navigation
Conversation
Contributor
Author
|
Another thing to do is upgrade to json v2 in >1.27.0, this pr would be slightly tweaked with that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON[T].Scandecoded into the existing value. When a scan destination is reused, nested pointers and slices retained by a previously returned row could be mutated by the next row; absent fields also survived subsequent scans.Decode each database value into a fresh
T, assigning it only after successful decoding. A SQL NULL resets the value. OrdinaryUnmarshalJSONbehavior is unchanged.Validation:
go test ./types, including regression coverage for retained previous rows, omitted fields, failed scans, and SQL NULL. Needed for Zeus to use Bob's existing JSON wrapper instead of model-specific scanners.