Skip to content

(Closes #1770) make eg20 compile - #3603

Merged
hiker merged 5 commits into
masterfrom
1770_make_eg20_compile
Sep 17, 2026
Merged

hiker merged 5 commits into
masterfrom
1770_make_eg20_compile

Conversation

@arporter

Copy link
Copy Markdown
Member

Adds a couple of extra files to our test copy of LFRic infrastructure and extends eg20 so that it compiles and links the example.

@arporter
arporter requested a review from hiker September 15, 2026 09:43
@arporter arporter self-assigned this Sep 15, 2026
@arporter arporter added enhancement ready for review LFRic Issue relates to the LFRic domain labels Sep 15, 2026
@arporter

Copy link
Copy Markdown
Member Author

A small PR that just extends the LFRic test infrastructure and then uses it to get eg20 to compile. One for @hiker :-)

@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (533ef7b) to head (772d102).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3603   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          402       402           
  Lines        56693     56693           
=========================================
  Hits         56693     56693           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hiker hiker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change. The code compiles and cleans as expected. I've triggered the IT, and will merge when this is green (CT linkcheck failures are caused by known issues with zeonodo atm).

@hiker
hiker deployed to integration September 17, 2026 02:13 — with GitHub Actions Active
@hiker
hiker merged commit c6bc3f2 into master Sep 17, 2026
14 of 17 checks passed
@hiker
hiker deleted the 1770_make_eg20_compile branch September 17, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement LFRic Issue relates to the LFRic domain ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants