Repository navigation
tests: Keep partition open across DOS type changes - #1562
Merged
Merged
Conversation
test_dos_type can fail with UnknownMethod when udev removes and recreates the partition between SetType() calls. The flight record shows the object disappearing after the invalid partition ID is rejected, with the next valid SetType() call arriving before the object is exported again. Keep the partition open throughout the sequence to prevent BLKRRPART from removing it between calls. Register the descriptor for cleanup before the partition is deleted.
vojtechtrefny
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_dos_type can fail with UnknownMethod when udev removes and recreates the partition between SetType() calls. The flight record shows the object disappearing after the invalid partition ID is rejected, with the next valid SetType() call arriving before the object is exported again.
Keep the partition open throughout the sequence to prevent BLKRRPART from removing it between calls. Register the descriptor for cleanup before the partition is deleted.