Repository navigation
perf(mock): avoid copying call slice in AssertNumberOfCalls - #1979
Closed
AdamMagued wants to merge 1 commit into
Closed
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
AssertNumberOfCalls previously invoked m.calls(), which creates a defensive clone of the entire m.Calls slice before iterating over it to count matching method calls. AssertNumberOfCalls already acquires and holds m.mutex across its execution and only reads call.Method. Iterating directly over m.Calls under the mutex lock eliminates redundant heap allocation and slice copying proportional to the call history length. Fixes stretchr#1957
Author
|
Closing in favor of earlier community PR #1958 to keep the review queue clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AssertNumberOfCalls currently calls
m.calls(), which creates a defensive copy of the entirem.Callsslice before iterating over it to count method invocations.AssertNumberOfCallsalready holdsm.mutexacross its entire execution and only readscall.Method. Iterating directly overm.Callsavoids allocating and copying the slice of calls without changing concurrency safety or assertion semantics.Fixes #1957