Fix two output bugs in pysu2_nastran - #2901
Merged
pcarruscag merged 2 commits intoSep 17, 2026
Merged
Conversation
The format string had no placeholder, so the number of points in the FSI marker was computed but never shown in the mesh summary.
There was a problem hiding this comment.
🟢 Approval recommended
The focused change has no unresolved review issues.
Pull request overview
Fixes the Nastran mesh summary to display the moving-marker point count.
Changes:
- Adds the missing format placeholder to the output string.
File summaries
| File | Description |
|---|---|
SU2_PY/SU2_Nastran/pysu2_nastran.py |
Corrects moving-marker point-count output. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The exception referenced self.tipo, which does not exist, so an unknown motion type raised AttributeError instead of the intended message. Use self.typeOfMotion.
ManasBagul23
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In
SU2_PY/SU2_Nastran/pysu2_nastran.py, the mesh summary prints"Number of points in the moving marker".format(len(...)). The string has no{}placeholder, so the count is computed but never shown. This adds the missing placeholder.Before:
Number of points in the moving markerAfter:
Number of points in the moving marker: 123Found with pyflakes (
'...'.format(...) has unused arguments at position(s): 0).The exception for an unknown imposed motion type referenced
self.tipo, which does not exist, so it raisedAttributeError: 'ImposedMotionClass' object has no attribute 'tipo'instead of the intended message. It now usesself.typeOfMotion.Related Work
None. This does not touch the SET1 parsing discussed in #2313.
PR Checklist
pre-commit run --allto format old commits.