Fix option names in config_template.cfg that SU2 does not accept - #2904
Closed
ManasBagul23 wants to merge 1 commit into
Closed
ManasBagul23 wants to merge 1 commit into
ManasBagul23 wants to merge 1 commit into
Conversation
Eight options in the template are rejected with "invalid option name": - NETTHRUST_DBCTHRUST, HOLD_GRID_FIXED_COORDS and DEFORM_POISSON_RATIO are misspellings of DNETTHRUST_DBCTHRUST, HOLD_GRID_FIXED_COORD and DEFORM_POISSONS_RATIO. - BUFFET_MONITORING, SINGLEZONE_DRIVER, SMOOTH_GEOMETRY and THERMAL_DIFFUSIVITY were removed from CConfig. - IGNITION_TEMPERATURE was never registered; the flame thickness threshold it describes is FLAME_INIT_IGNITION, so that description is moved there.
There was a problem hiding this comment.
🟡 Changes recommended
The Python config reader still injects BUFFET_MONITORING, which CConfig now rejects.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates config_template.cfg to use valid SU2 option names and remove unsupported entries.
Changes:
- Corrects misspelled option names.
- Removes deprecated or unregistered options.
- Updates buffet and flame ignition documentation.
File summaries
| File | Description |
|---|---|
config_template.cfg |
Aligns template options and descriptions with current SU2 configuration support. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+667
to
+669
| % The Kenway-Martins separation sensor for buffet-onset detection is computed | ||
| % on Navier-Stokes markers. If BUFFET objective/constraint is specified, the | ||
| % objective is given by the integrated sensor normalized by reference area |
Author
There was a problem hiding this comment.
The Python side (the key injected in SU2_PY/SU2/io/config.py) is fixed in #2905, so the two PRs together cover both places.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Eight options in
config_template.cfgare rejected bySU2_CFDwithinvalid option name, so a config copied from the template does not run:NETTHRUST_DBCTHRUSTDNETTHRUST_DBCTHRUSTHOLD_GRID_FIXED_COORDSHOLD_GRID_FIXED_COORDDEFORM_POISSON_RATIODEFORM_POISSONS_RATIOBUFFET_MONITORINGSINGLEZONE_DRIVERSMOOTH_GEOMETRYTHERMAL_DIFFUSIVITYIGNITION_TEMPERATUREFLAME_INIT_IGNITION(Flame_T_ignition)FLAME_INIT_IGNITIONAfter this change every option in the template is registered in
CConfig.cppon develop.Related Work
Closes #2914.
IGNITION_TEMPERATUREcame in with #2733.PR Checklist
pre-commit run --allto format old commits.